bigquery: implement regionalization #3131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
pongad
commented
Apr 5, 2018
| import com.google.cloud.bigquery.BigQueryException; | ||
| import java.util.Map; | ||
|
|
||
| @InternalExtensionOnly |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
tswast
reviewed
Apr 9, 2018
| import com.google.cloud.bigquery.BigQueryException; | ||
| import java.util.Map; | ||
|
|
||
| @InternalExtensionOnly |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| assertThat(bigquery.getJob(job.getJobId())).isNotNull(); | ||
|
|
||
| // Wrong location shouldn't work. | ||
| assertThat(bigquery.getJob(job.getJobId().toBuilder().setLocation(wrongLocation).build())) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| table.getTableId().getDataset(), | ||
| table.getTableId().getTable()); | ||
| Job job = | ||
| bigquery.create( |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
tswast
approved these changes
Apr 10, 2018
| TableDataWriteChannel writer(WriteChannelConfiguration writeChannelConfiguration); | ||
|
|
||
| // TODO(pongad): document | ||
| TableDataWriteChannel writer(JobId jobId, WriteChannelConfiguration writeChannelConfiguration); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
|
We should follow this PR with another change that adds location to BigQueryOptions or something (a peer to where the default project is set). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.