Skip to content

Conversation

@pongad
Copy link
Contributor

@pongad pongad commented Apr 4, 2018

We also add JobId.Builder since the static constructors are getting
unwieldy.
The property isn't threaded through in the right places yet, so we keep
it package-private for now.

We also add JobId.Builder since the static constructors are getting
unwieldy.
The property isn't threaded through in the right places yet, so we keep
it package-private for now.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 4, 2018
@pongad
Copy link
Contributor Author

pongad commented Apr 4, 2018

FYI @jjolma

Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I see that query has an overload to set the jobId, but writer does not. Could we add a JobId parameter there, too?

@pongad
Copy link
Contributor Author

pongad commented Apr 4, 2018

@tswast I created #3126 to track.

@pongad pongad merged commit 58d2851 into googleapis:master Apr 4, 2018
@pongad pongad deleted the bq-region branch April 4, 2018 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants