Skip to content

update maven enforcer #3120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jeanbza merged 1 commit into from
Apr 5, 2018
Merged

update maven enforcer #3120

jeanbza merged 1 commit into from
Apr 5, 2018

Conversation

@jeanbza
Copy link

@jeanbza jeanbza commented Apr 3, 2018 •
edited
Loading

This updates maven enforcer to the latest stable (and recommended) release. It fixes a compilation failure in java 9.

Part of work on #3027.

@jeanbza
internal: update maven enforcer
9fbbf44 
This updates maven enforcer to the latest stable (and recommended)
release. It fixes a compilation failure in java 9.
@jeanbza jeanbza requested a review from pongad as a code owner April 3, 2018 21:42
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 3, 2018
@garrettjonesgoogle
Copy link
Member

garrettjonesgoogle commented Apr 3, 2018

Do you know what the M1 qualifier means?

@jeanbza
Copy link
Author

jeanbza commented Apr 3, 2018

Milestone 1. It usually means something like "part 1 of 3", which turned me off using this release, but the page mentions:

This is the current stable version of Apache Maven Enforcer.

So I suppose they have some different nomenclature.

@garrettjonesgoogle
Copy link
Member

garrettjonesgoogle commented Apr 3, 2018

LGTM

@pongad
Copy link
Contributor

pongad commented Apr 4, 2018

@jadekler Are you able to merge to this repo? If not, please let us know.

@jeanbza
Copy link
Author

jeanbza commented Apr 4, 2018

@pongad I am! Should I? Wasn't sure what the flow is heh

@pongad
Copy link
Contributor

pongad commented Apr 5, 2018

We usually write LGTM or something similar and let people with write access merge at their leisure. We usually use "squash and merge" option and clean up commit message though. Of course, if you need to land a big feature, we're not completely against merging a branch.

@jeanbza jeanbza merged commit c8f3624 into googleapis:master Apr 5, 2018
@jeanbza
Copy link
Author

jeanbza commented Apr 5, 2018

Thanks! Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pongad pongad Awaiting requested review from pongad

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jeanbza @garrettjonesgoogle @pongad @googlebot