Skip to content

Bigtable: Make models serializable. #3106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pongad merged 2 commits into from
Apr 6, 2018
Merged

Bigtable: Make models serializable. #3106

pongad merged 2 commits into from
Apr 6, 2018

Conversation

@igorbernstein2
Copy link

@igorbernstein2 igorbernstein2 commented Mar 29, 2018 •
edited
Loading

This along with query sharding, enables the creation of a Beam Source

@igorbernstein2
Bigtable: Make models serializable.
c6c0e57 
Thism along with query sharding, enables the creation of a Beam Source
@igorbernstein2 igorbernstein2 requested a review from pongad as a code owner March 29, 2018 16:40
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 29, 2018
@igorbernstein2
Copy link
Author

igorbernstein2 commented Apr 2, 2018

@garrettjonesgoogle This is ready for review/merging

pongad
pongad reviewed Apr 2, 2018
View reviewed changes
Copy link
Contributor

@pongad pongad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @garrettjonesgoogle Do you want to take a look?

garrettjonesgoogle
garrettjonesgoogle approved these changes Apr 2, 2018
View reviewed changes
Copy link
Member

@garrettjonesgoogle garrettjonesgoogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@igorbernstein2
Copy link
Author

igorbernstein2 commented Apr 5, 2018

please merge when ready

@pongad pongad merged commit 3dc830e into googleapis:master Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@pongad pongad pongad left review comments

@garrettjonesgoogle garrettjonesgoogle garrettjonesgoogle approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@igorbernstein2 @pongad @garrettjonesgoogle @googlebot