Skip to content

Conversation

@neozwu
Copy link
Contributor

@neozwu neozwu commented Mar 26, 2018

This change adds a mvn profile to run smoke tests (by invoking "mvn -P smoke-test verify") once a separate change (googleapis/gapic-generator#1898) is used to generate code.

@neozwu neozwu requested a review from vam-google March 26, 2018 21:26
@neozwu neozwu requested a review from pongad as a code owner March 26, 2018 21:26
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 26, 2018
pom.xml Outdated
</includes>
<excludes>
<exclude>**/*IT.java</exclude>
</excludes>

This comment was marked as spam.

@neozwu
Copy link
Contributor Author

neozwu commented Mar 27, 2018

@garrettjonesgoogle PTAL

Copy link
Member

@garrettjonesgoogle garrettjonesgoogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@vam-google vam-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neozwu neozwu merged commit 89082b3 into googleapis:master Mar 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants