dlp: add a utility conversion function #3028

jeanbza · 2018-03-13T00:18:48Z

There's a lot about this I'm unsure about, since this is my first commit. So, sorry if a lot is wrong here.

pongad

On the contrary, most things look right :)

google-cloud-dlp/src/main/java/com/google/cloud/dlp/v2beta1/ColorUtil.java

+
+  private ColorUtil() {}
+
+  public static final Color convert(java.awt.Color c) {


google-cloud-dlp/src/main/java/com/google/cloud/dlp/v2beta1/ColorUtil.java

+
+  private ColorUtil() {}
+
+  public static final Color convert(java.awt.Color c) {


google-cloud-dlp/src/main/java/com/google/cloud/dlp/v2beta1/ColorUtil.java

+
+import com.google.privacy.dlp.v2beta1.Color;
+
+public class ColorUtil {


google-cloud-dlp/src/main/java/com/google/cloud/dlp/v2beta1/ColorUtil.java

+        .setGreen(c.getGreen())
+        .setRed(c.getRed())
+        .build();
+  }


Fixes issue googleapis#2321

jeanbza · 2018-03-14T22:05:46Z

@garrettjonesgoogle PTAL and lmk if anything else to fix up!

google-cloud-dlp/src/test/java/com/google/cloud/dlp/v2beta1/ColorTest.java

+    Color got = Colors.asDlpColor(java.awt.Color.GREEN);
+    Assert.assertEquals(got.getBlue(), 0, 0);
+    Assert.assertEquals(got.getGreen(), 255, 0);
+    Assert.assertEquals(got.getRed(), 0, 0);


google-cloud-dlp/src/main/java/com/google/cloud/dlp/v2beta1/Colors.java

+
+  private Colors() {}
+
+  public static final Color asDlpColor(java.awt.Color c) {


jeanbza · 2018-03-14T22:47:09Z

@garrettjonesgoogle PTAL

garrettjonesgoogle

LGTM

jeanbza requested a review from pongad as a code owner March 13, 2018 00:18

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 13, 2018

jeanbza force-pushed the dlp_color branch from 819d036 to 2f1b259 Compare March 13, 2018 00:26

pongad reviewed Mar 13, 2018

View reviewed changes

garrettjonesgoogle reviewed Mar 14, 2018

View reviewed changes

dlp: add a utility conversion function

be2631d

Fixes issue googleapis#2321

jeanbza force-pushed the dlp_color branch from 2f1b259 to be2631d Compare March 14, 2018 19:39

garrettjonesgoogle reviewed Mar 14, 2018

View reviewed changes

add asAwtColor conversion function + test

fcf2880

garrettjonesgoogle approved these changes Mar 14, 2018

View reviewed changes

pongad merged commit 4fbe331 into googleapis:master Mar 14, 2018


		private ColorUtil() {}

		public static final Color convert(java.awt.Color c) {


		import com.google.privacy.dlp.v2beta1.Color;

		public class ColorUtil {


		private Colors() {}

		public static final Color asDlpColor(java.awt.Color c) {

dlp: add a utility conversion function #3028

dlp: add a utility conversion function #3028

Uh oh!

Conversation

jeanbza commented Mar 13, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pongad left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

jeanbza commented Mar 14, 2018

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

jeanbza commented Mar 14, 2018

Uh oh!

garrettjonesgoogle left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jeanbza commented Mar 13, 2018 •

edited

Loading