Skip to content

Conversation

@vam-google
Copy link
Contributor

@vam-google vam-google commented Feb 21, 2018

Also:
fix javadoc issue in Role.java file;
fix s/google-cloud-bom.version/bom.version to fix the version update script;
fix root README.md version from 0.33.0 (should be 0.34.0) directly to 0.35.0);
fix javadoc issue in LocalStorageHelper.java.

@vam-google vam-google requested a review from pongad as a code owner February 21, 2018 01:51
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 21, 2018
…ust bom.version property (to stay consistent with how we name those .version properties and fix the update_versions.sh script).
@vam-google
Copy link
Contributor Author

@garrettjonesgoogle PTAL

Copy link
Member

@garrettjonesgoogle garrettjonesgoogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vam-google vam-google merged commit c28951c into googleapis:master Feb 21, 2018
meltsufin pushed a commit that referenced this pull request Dec 22, 2025
Also:
fix javadoc issue in Role.java file;
fix s/google-cloud-bom.version/bom.version to fix the version update script;
fix root README.md version from 0.33.0 (should be 0.34.0) directly to 0.35.0);
fix javadoc issue in LocalStorageHelper.java.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants