Skip to content

Initial interface for transaction manager for manually managing retries of a transaction #2776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vkedia merged 26 commits into from
Apr 13, 2018
Merged

Initial interface for transaction manager for manually managing retries of a transaction #2776

vkedia merged 26 commits into from
Apr 13, 2018

Conversation

@vkedia
Copy link

@vkedia vkedia commented Jan 12, 2018

vkedia added 18 commits November 17, 2017 15:58
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 12, 2018
@vkedia vkedia mentioned this pull request Jan 12, 2018
Closed
tomayles
tomayles reviewed Jan 16, 2018
View reviewed changes
google-cloud-spanner/src/main/java/com/google/cloud/spanner/DatabaseClient.java
*/
TransactionRunner readWriteTransaction();

TransactionManager transactionManager();

This comment was marked as spam.

Sign in to view

tomayles
tomayles approved these changes Jan 16, 2018
View reviewed changes
google-cloud-spanner/src/main/java/com/google/cloud/spanner/TransactionManager.java
* Creates a new transaction for retry. This should only be called if the previous transaction
* failed with {@code ABORTED}. In all other cases, this will throw a {@link SpannerException}.
*/
TransactionContext resetForRetry();

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

google-cloud-spanner/src/main/java/com/google/cloud/spanner/TransactionManager.java Outdated
TransactionContext resetForRetry();

/**
* Returns the commit timestamp if the transaction committed successfully.

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@vkedia vkedia requested a review from pongad as a code owner April 12, 2018 00:50
@vkedia
Copy link
Author

vkedia commented Apr 12, 2018

@snehashah16 @pongad @hzyi-google Please review this.

@vkedia vkedia requested a review from snehashah16 April 12, 2018 00:57
@pongad
Copy link
Contributor

pongad commented Apr 12, 2018

I'm not familiar enough with Spanner to properly review this, but as far as my feeble powers go, LGTM

@vkedia
Copy link
Author

vkedia commented Apr 12, 2018

Thanks. I have added @snehashah16 from my team to do a thorough review.

snehashah16
snehashah16 approved these changes Apr 12, 2018
View reviewed changes
Copy link
Contributor

@snehashah16 snehashah16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vkedia
Copy link
Author

vkedia commented Apr 13, 2018

@snehashah16 thanks for the quick review.
@pongad @hzyi-google what command do I run to insert the snippet into javadoc?

@vkedia vkedia merged commit c0d4b28 into googleapis:master Apr 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@garrettjonesgoogle garrettjonesgoogle Awaiting requested review from garrettjonesgoogle

@pongad pongad Awaiting requested review from pongad

2 more reviewers

@tomayles tomayles tomayles approved these changes

@snehashah16 snehashah16 snehashah16 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vkedia @pongad @tomayles @snehashah16 @googlebot