Make Translate auth documentation clear and consistent #2208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additional updates prompted by googleapis#1594 / googleapis#2147.
googlebot
added
the
cla: yes
This was referenced Jun 30, 2017
Merged
|
Changes Unknown when pulling c37d55e on tcoffee-google:clarify_adc_auth into ** on GoogleCloudPlatform:master**. |
|
Changes Unknown when pulling 320a61b on tcoffee-google:clarify_adc_auth into ** on GoogleCloudPlatform:master**. |
|
Changes Unknown when pulling 8353ebd on tcoffee-google:clarify_adc_auth into ** on GoogleCloudPlatform:master**. |
vkedia
added a commit
that referenced
this pull request
Apr 14, 2018
This method already has a snippet. It was manually changed to put under <code> block instead of @code in #2208 due to javadoc bug https://bugs.openjdk.java.net/browse/JDK-8130754 When I reran the add snippets tool to add the snippets for a different method, it did not detect the existing snippet on readWriteTransaction and again added the same snippet under @code block which fails. My change removes the duplicate snippet but next time we add a new spanner snippet, we will again run into this issue. Ideally we should fix the add snippet tool to handle this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional updates prompted by #1594 / #2147.