Discourage use of API key in translation #2147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
tcoffee-google
force-pushed
the
translate_api_key
branch
from
780042d to
42afcd1
Compare
Contributor
Author
|
@gguuss PTAL |
Contributor
|
Code looked good but Travis test is failing. Once it passes the change should resolve the issue. |
Contributor
Author
|
Travis is currently hitting a build time limit on OS X. |
tcoffee-google
added a commit
to tcoffee-google/google-cloud-java
that referenced
this pull request
Jun 30, 2017
Additional updates prompted by googleapis#1594 / googleapis#2147.
tcoffee-google
added a commit
that referenced
this pull request
Jul 14, 2017
* Make Translate auth documentation clear and consistent Additional updates prompted by #1594 / #2147. * Fix doc link * Fix Spanner doc example * Work around Javadoc bug https://bugs.openjdk.java.net/browse/JDK-8130754
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1594.