Skip to content

Conversation

@garrettjonesgoogle
Copy link
Member

Build will fail because GAX won't be released until after this PR is provisionally approved.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 22, 2017
<google.auth.version>0.6.0</google.auth.version>
<grpc.version>1.0.3</grpc.version>
<gax.version>0.5.0</gax.version>
<gax.version>0.6.0</gax.version>

This comment was marked as spam.

This comment was marked as spam.

Copy link
Contributor

@michaelbausor michaelbausor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending GAX release and tests passing

@shinfan
Copy link
Contributor

shinfan commented Mar 22, 2017

LGTM

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 23662c0 on garrettjonesgoogle:master into ** on GoogleCloudPlatform:master**.

@garrettjonesgoogle garrettjonesgoogle merged commit 2404d30 into googleapis:master Mar 22, 2017
meltsufin pushed a commit that referenced this pull request Dec 22, 2025
* bugfix: make exception for non-cloud artifacts

* change format
Source-Link: googleapis/synthtool@a86e189
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:944c07e458ce227ca49a423affedf088e31e2ee70908dd21682238d58f1beb60

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants