Repository navigation
feat(storage): add enterprise storage classes - #14955
mukeshbhangria wants to merge 2 commits into
Conversation
Add STANDARD_ENTERPRISE, LR_STANDARD_ENTERPRISE, and STANDARD_FLEXBACKUP_ENTERPRISE constants to StorageClass along with unit tests. [Generated-by: AI]
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds three new storage classes to StorageClass.java: STANDARD_ENTERPRISE, LR_STANDARD_ENTERPRISE, and STANDARD_FLEXBACKUP_ENTERPRISE, and introduces a new test class StorageClassTest.java to validate them. The feedback suggests formatting the import statements in the new test file to comply with the Google Java Style Guide by grouping and separating them with blank lines.
| package com.google.cloud.storage; | ||
| import static com.google.common.truth.Truth.assertThat; | ||
| import static org.junit.Assert.assertEquals; | ||
| import static org.junit.Assert.assertNotNull; | ||
| import static org.junit.Assert.assertSame; | ||
| import static org.junit.Assert.assertThrows; | ||
| import java.util.Arrays; | ||
| import org.junit.Test; | ||
| public class StorageClassTest { |
There was a problem hiding this comment.
According to the Google Java Style Guide (Section 3.3.3), import statements must be grouped and separated by a single blank line (static imports first, then non-static imports). Additionally, there should be a blank line between the package declaration and the imports, and between the imports and the class declaration.
package com.google.cloud.storage;
import static com.google.common.truth.Truth.assertThat;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertNotNull;
import static org.junit.Assert.assertSame;
import static org.junit.Assert.assertThrows;
import java.util.Arrays;
import org.junit.Test;
public class StorageClassTest {References
- Google Java Style Guide Section 3.3.3: Imports are grouped into static and non-static blocks, separated by a single blank line. There should also be blank lines separating the package declaration, imports, and class declaration. (link)
Adds
STANDARD_ENTERPRISE,LR_STANDARD_ENTERPRISE, andSTANDARD_FLEXBACKUP_ENTERPRISEconstants toStorageClassand unit tests inStorageClassTest.