Repository navigation
fix(bigquery-jdbc): correct isLast() with setMaxRows, guard Arrow getters, decode Arrow batches without copying - #14951
Open
keshavdandeva wants to merge 3 commits into
Open
keshavdandeva wants to merge 3 commits into
keshavdandeva wants to merge 3 commits into
Conversation
…ters, decode Arrow batches without copying
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request optimizes Arrow batch deserialization by reading directly from ByteString, adds row-position validation to BigQueryArrowResultSet.getObjectInternal, and introduces a helper method getEffectiveTotalRows to cap the total rows correctly. The feedback recommends using asReadOnlyByteBuffer() with a custom ReadableByteChannel to achieve true zero-copy deserialization instead of Channels.newChannel, and moving the row-position guard check to the beginning of getObjectInternal to ensure it also covers nested columns.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
b/583949767
This PR fixes three result-set issues:
isLast()was never true whensetMaxRowswas larger than the result (JSON and Arrow). A shared helper now caps the total atmaxRows.SQLException. Beforenext()they threwIndexOutOfBoundsException, and after the last row they returned a stale value.ByteString, with no heapbyte[]copy.