chore(spanner): use DeliverTime column and RECEIVE_MyQueue TVF in queue - #14354
Merged
Merged
Conversation
sakthivelmanii
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the queue sample to use the correct DeliverTime column in the insert statement and switches the queue reading function to RECEIVE_MyQueue. However, because RECEIVE_MyQueue is a mutating operation, executing it within a read-only transaction (dbClient.singleUse()) will result in a runtime error. It should be executed within a read-write transaction instead.
Comment on lines
164
to
+165
| try (ResultSet resultSet = dbClient.singleUse().executeQuery( | ||
| Statement.of("SELECT * FROM READ_MyQueue(max_duration => '1m')"))) { | ||
| Statement.of("SELECT * FROM RECEIVE_MyQueue(max_duration => '1m')"))) { |
Contributor
There was a problem hiding this comment.
The RECEIVE_MyQueue table-valued function (TVF) is a mutating queue operation (it leases/dequeues messages, modifying the queue state). In Cloud Spanner, mutating operations cannot be executed within a read-only transaction, such as dbClient.singleUse(). Attempting to do so will result in a runtime error.
To resolve this, execute the query within a read-write transaction instead:
dbClient.readWriteTransaction().run(
transaction -> {
try (ResultSet resultSet = transaction.executeQuery(
Statement.of("SELECT * FROM RECEIVE_MyQueue(max_duration => '1m')"))) {
if (resultSet.next()) {
System.out.println("Received message ID: " + resultSet.getLong("Id"));
} else {
System.out.println("No message received");
}
}
return null;
});
Contributor
Author
There was a problem hiding this comment.
it's reading from queue only
olavloite
approved these changes
Sep 11, 2026
sakthivelmanii
enabled auto-merge (squash)
September 11, 2026 14:37
sakthivelmanii
force-pushed
the
fix-spanner-queue-sample-columns
branch
from
September 11, 2026 15:33
bab0645 to
a36c8ef
Compare
sakthivelmanii
disabled auto-merge
September 11, 2026 16:30
sakthivelmanii
enabled auto-merge (squash)
September 11, 2026 16:31
lqiu96
approved these changes
Sep 11, 2026
lqiu96
added a commit
that referenced
this pull request
Sep 14, 2026
…4366) In .kokoro/build.sh, changed_file_list used a two-dot git diff (${BASE_SHA} ${HEAD_SHA}), which compares BASE_SHA directly to HEAD_SHA. When BASE_SHA moves ahead on main after the PR branch diverges, files merged into main on other modules were erroneously included in the diff. Switch to a three-dot git diff (${BASE_SHA}...${HEAD_SHA}) to diff against the merge base between BASE_SHA and HEAD_SHA, matching .kokoro/common.sh get_modified_files() behavior. Logs from lint job in #14354 which only touched a spanner file: ``` java-bigquery-jdbc/src/main/java/com/google/cloud/bigquery/jdbc/BigQueryArrowArray.java java-bigquery-jdbc/src/main/java/com/google/cloud/bigquery/jdbc/BigQueryArrowResultSet.java java-bigquery-jdbc/src/main/java/com/google/cloud/bigquery/jdbc/BigQueryArrowStruct.java java-bigquery-jdbc/src/main/java/com/google/cloud/bigquery/jdbc/BigQueryBaseArray.java java-bigquery-jdbc/src/main/java/com/google/cloud/bigquery/jdbc/BigQueryBaseStruct.java java-bigquery-jdbc/src/main/java/com/google/cloud/bigquery/jdbc/BigQueryStatement.java java-bigquery-jdbc/src/main/java/com/google/cloud/bigquery/jdbc/BigQueryTemporalUtility.java java-bigquery-jdbc/src/test/java/com/google/cloud/bigquery/jdbc/BigQueryArrowArrayOfPrimitivesTest.java java-bigquery-jdbc/src/test/java/com/google/cloud/bigquery/jdbc/BigQueryArrowResultSetTest.java java-bigquery-jdbc/src/test/java/com/google/cloud/bigquery/jdbc/BigQueryArrowStructTest.java java-bigquery-jdbc/src/test/java/com/google/cloud/bigquery/jdbc/BigQueryJdbcCustomLoggerTest.java java-bigquery-jdbc/src/test/java/com/google/cloud/bigquery/jdbc/BigQueryStatementTest.java java-bigquery-jdbc/src/test/java/com/google/cloud/bigquery/jdbc/BigQueryTemporalUtilityTest.java java-spanner/samples/snippets/src/main/java/com/example/spanner/QueueSample.java Matched: java-bigquery-jdbc/src/main/java/com/google/cloud/bigquery/jdbc/BigQueryArrowArray.java Changed Modules: java-bigquery-jdbc java-bigquery-jdbc java-bigquery-jdbc java-bigquery-jdbc java-bigquery-jdbc java-bigquery-jdbc java-bigquery-jdbc java-bigquery-jdbc java-bigquery-jdbc java-bigquery-jdbc java-bigquery-jdbc java-bigquery-jdbc java-bigquery-jdbc Formatting only changed modules: java-bigquery-jdbc ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.