Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
whowes
added this pull request to stack #14327
September 9, 2026 06:35
whowes
force-pushed
the
whowes/generator-settings-codegen
branch
from
September 9, 2026 15:50
9e50315 to
e99b1f1
Compare
whowes
force-pushed
the
whowes/generator-settings-codegen
branch
from
September 9, 2026 20:16
e99b1f1 to
14d6389
Compare
whowes
removed this pull request from stack #14327
September 9, 2026 23:45
whowes
added this pull request to stack #14343
September 9, 2026 23:47
whowes
force-pushed
the
whowes/generator-settings-codegen
branch
from
September 9, 2026 23:50
14d6389 to
74e2bea
Compare
whowes
force-pushed
the
whowes/generator-settings-codegen
branch
from
September 10, 2026 01:15
74e2bea to
b03ac25
Compare
whowes
force-pushed
the
whowes/generator-settings-codegen
branch
from
September 10, 2026 06:04
b03ac25 to
fb557d9
Compare
whowes
force-pushed
the
whowes/generator-settings-codegen
branch
from
September 11, 2026 17:23
fb557d9 to
8f9a345
Compare
whowes
removed this pull request from stack #14343
September 11, 2026 17:25
whowes
added this pull request to stack #14363
September 11, 2026 17:25
whowes
force-pushed
the
whowes/generator-settings-codegen
branch
from
September 11, 2026 20:00
8f9a345 to
2c56792
Compare
whowes
force-pushed
the
whowes/generator-settings-codegen
branch
from
September 11, 2026 21:13
2c56792 to
675dd7d
Compare
whowes
force-pushed
the
whowes/generator-settings-codegen
branch
from
September 11, 2026 21:39
675dd7d to
6eaf35a
Compare
whowes
force-pushed
the
whowes/generator-settings-codegen
branch
from
September 14, 2026 21:34
6eaf35a to
8e793ed
Compare
|
|
blakeli0
reviewed
Sep 14, 2026
| * <p>Note that custom retry settings and headers configured via ApiCallContext apply strictly | ||
| * to the initial session initiation request. | ||
| */ | ||
| public ResumableUploadCallSettings.Builder uploadMediaSettings() { |
Contributor
There was a problem hiding this comment.
I think uploadMediaSettings method in this ServiceSettings file and StubSettings below are newly generated?
| /** | ||
| * Returns the builder for the settings used for calls to uploadMedia. | ||
| * | ||
| * <p>Note that custom retry settings and headers configured via ApiCallContext apply strictly |
Contributor
There was a problem hiding this comment.
I don't think we can configure headers via ApiCallContext in settings. It does apply to the callable since ApiCallContext is only exposed there.
whowes
removed this pull request from stack #14363
September 14, 2026 22:18
whowes
added this pull request to stack #14381
September 14, 2026 22:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds generator support for emitting
ResumableUploadCallSettingson stub and service settings classes to support protocol-specific upload options. Resumable upload settings are populated with global timeouts extracted from the service configuration while bypassing standard unary retries.