fix: deprecate resource detector#13844
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request migrates the GCP platform detection in EnvInfo from the legacy GCPPlatformDetector to the OpenTelemetry-native GCPResourceProvider, updating the pom.xml dependencies, refactoring EnvInfo to use OpenTelemetry Attributes, and adapting the unit tests accordingly. The review feedback recommends avoiding eager initialization of GCPResourceProvider as a static final field to prevent potential blocking operations or network I/O during class loading, suggesting instead to instantiate it lazily inside the detect() method.
psx95
approved these changes
Jul 21, 2026
blakeli0
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.