feat(auth): add JSpecify Null annotations to Auth#13842
Open
nnicolee wants to merge 10 commits into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
nnicolee
force-pushed
the
feat/jspecify-auth
branch
from
July 21, 2026 04:39
76c939a to
afdc8c6
Compare
nnicolee
force-pushed
the
feat/jspecify-auth
branch
from
July 21, 2026 04:43
afdc8c6 to
432c5d0
Compare
lqiu96
reviewed
Jul 22, 2026
lqiu96
reviewed
Jul 22, 2026
lqiu96
approved these changes
Jul 22, 2026
Member
|
/gemini review |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
lqiu96
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Contributor
Author
|
/gemini review |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
nnicolee
marked this pull request as ready for review
July 23, 2026 04:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR migrates the Google Auth Library for Java (
google-auth-library-java) to use JSpecify 1.0.0 nullability annotations (@NullMarkedand@Nullable), replacing the previousjavax.annotationreferences.Key Changes
JSpecify 1.0.0 Annotation Adoption in Auth:
@NullMarkedat the class and package levels across core auth classes (incredentials,oauth2_http,appengine, andcab-token-generatormodules) to define non-null by default semantics.javax.annotation.Nullablewithorg.jspecify.annotations.Nullable.pom.xmlfiles and BazelBUILD.bazelconfigurations to declare and manage theorg.jspecify:jspecifydependency.Verification Results