Skip to content

fix(bigquery-jdbc): shade org.slf4j #13547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
logachev wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −0
Open

fix(bigquery-jdbc): shade org.slf4j #13547

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions java-bigquery-jdbc/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,10 @@
<pattern>org.json</pattern>
<shadedPattern>com.google.bqjdbc.shaded.org.json</shadedPattern>
</relocation>
<relocation>
<pattern>org.slf4j</pattern>
<shadedPattern>com.google.bqjdbc.shaded.org.slf4j</shadedPattern>
</relocation>
Comment on lines +155 to +158

@gemini-code-assist gemini-code-assist Bot Jun 24, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Shading org.slf4j causes the JDBC driver's internal logging to be completely silenced. Because the host application's logging backend (e.g., Logback, Log4j2) binds to the standard org.slf4j package, the relocated com.google.bqjdbc.shaded.org.slf4j classes will fail to find a binding and default to a no-op logger (NOPLogger). This prevents users from capturing or configuring logs from the JDBC driver and its shaded dependencies (such as gRPC), which severely impacts troubleshooting and supportability.

<relocation>
<pattern>io.grpc</pattern>
<shadedPattern>com.google.bqjdbc.shaded.io.grpc</shadedPattern>
Expand Down
Loading