fix(bigquery-jdbc): shade org.slf4j#13547
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a relocation rule for the org.slf4j package to be shaded under com.google.bqjdbc.shaded.org.slf4j in the Maven configuration. Feedback indicates that shading org.slf4j will silence the JDBC driver's internal logging, as the host application's logging backend binds to the standard package, causing the relocated classes to default to a no-op logger.
| <relocation> | ||
| <pattern>org.slf4j</pattern> | ||
| <shadedPattern>com.google.bqjdbc.shaded.org.slf4j</shadedPattern> | ||
| </relocation> |
There was a problem hiding this comment.
Shading org.slf4j causes the JDBC driver's internal logging to be completely silenced. Because the host application's logging backend (e.g., Logback, Log4j2) binds to the standard org.slf4j package, the relocated com.google.bqjdbc.shaded.org.slf4j classes will fail to find a binding and default to a no-op logger (NOPLogger). This prevents users from capturing or configuring logs from the JDBC driver and its shaded dependencies (such as gRPC), which severely impacts troubleshooting and supportability.
1 participant
Fix #13468