Skip to content

chore(bigquery-jdbc): update integration tests to handle different cancellation #13541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
logachev merged 4 commits into from
Jun 23, 2026
+9 −7
Merged

chore(bigquery-jdbc): update integration tests to handle different cancellation #13541

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3689b44
chore(bigquery-jdbc): update integration tests to handle different ca…
logachev Jun 23, 2026
c204a51
lint
logachev Jun 23, 2026
5302044
feedback
logachev Jun 23, 2026
82ced9f
lint
logachev Jun 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ...-bigquery-jdbc/src/test/java/com/google/cloud/bigquery/jdbc/it/ITNightlyBigQueryTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,11 @@ public void testQueryInterruptGracefullyStopsExplicitJob()
});
t.start();
// Allow thread to actually initiate the query
Thread.sleep(3000);
// Even when job is created, we might be using `query` API which means if we cancle within first
// 10 seconds,
// it is similar to Optional job cancellation. Need to wait until after we're in "Wait for job
// completion" mode.
Thread.sleep(15000);
bigQueryStatement.cancel();
// Wait until background thread is finished
t.join();
Expand Down
10 changes: 4 additions & 6 deletions java-bigquery-jdbc/src/test/java/com/google/cloud/bigquery/jdbc/it/ITStatementTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,12 +331,10 @@ public void testSetTimeout() throws SQLException {
assertEquals(0, statement.getQueryTimeout());
statement.setQueryTimeout(1);
assertEquals(1, statement.getQueryTimeout());
try {
statement.executeQuery(selectQuery);
} catch (SQLException e) {
assertTrue(true);
assertEquals("SQL execution canceled", e.getMessage());
}
SQLException e = assertThrows(SQLException.class, () -> statement.executeQuery(selectQuery));
assertEquals(
"BigQueryException during runQuery\nJob execution was cancelled: Job timed out",
e.getMessage());
statement.close();
connection.close();
}
Expand Down
Loading