chore(bigquery-jdbc): update integration tests to handle different cancellation#13541
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates integration tests for the BigQuery JDBC driver. In ITNightlyBigQueryTest, the sleep duration before cancellation is increased to 15 seconds to ensure the job is in the appropriate state, and a debug print statement is added. In ITStatementTest, the expected exception message for a timed-out query is updated. Feedback suggests removing the leftover System.out.println debugging statement and refactoring the try-catch block in ITStatementTest to use assertThrows to ensure the test fails if no exception is thrown.
keshavdandeva
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to 64cde7f now
jobs.queryAPI is used even if we request job creation (Previously it falls back tojobs.insert). Due to this, updating integration test with new error/timeout values.