Rename setters/getters/builders for Datastore classes to meet proto conventions #1315

mziccard · 2016-10-13T13:15:42Z

No description provided.

…onventions

…s/setters/builders

coveralls · 2016-10-13T13:55:56Z

Coverage decreased (-0.1%) to 84.543% when pulling b7a5c2f on mziccard:datastore-rename into 513ca70 on GoogleCloudPlatform:master.

mziccard · 2016-10-13T18:25:39Z

/cc @lesv

google-cloud-datastore/src/main/java/com/google/cloud/datastore/IncompleteKey.java

   */
  @Override
+  @Deprecated
  public Key parent() {


google-cloud-datastore/src/test/java/com/google/cloud/datastore/BaseKeyTest.java

  public void testNamespace() throws Exception {
+    Builder builder = new Builder("ds", "k");
+    BaseKey key = builder.build();
+    assertTrue(key.getNamespace() != null);


lesv

LGTM - I have a couple of questions, but none of them block merging. You can also ignore the codacy-bot.

coveralls · 2016-10-14T16:15:12Z

Coverage decreased (-0.08%) to 84.593% when pulling 5e99922 on mziccard:datastore-rename into 513ca70 on GoogleCloudPlatform:master.

…14.6 (#1315) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-bigquery](https://togithub.com/googleapis/java-bigquery) | `2.14.4` -> `2.14.6` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-bigquery/2.14.6/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-bigquery/2.14.6/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-bigquery/2.14.6/compatibility-slim/2.14.4)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-bigquery/2.14.6/confidence-slim/2.14.4)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-bigquery</summary> ### [`v2.14.6`](https://togithub.com/googleapis/java-bigquery/blob/HEAD/CHANGELOG.md#2146-httpsgithubcomgoogleapisjava-bigquerycomparev2145v2146-2022-08-12) [Compare Source](https://togithub.com/googleapis/java-bigquery/compare/v2.14.5...v2.14.6) ##### Dependencies - update dependency com.google.cloud:google-cloud-datacatalog-bom to v1.9.2 ([#2221](https://togithub.com/googleapis/java-bigquery/issues/2221)) ([3292cdd](https://togithub.com/googleapis/java-bigquery/commit/3292cddeec7c83fa198a96d80a35c13b003a26c8)) ### [`v2.14.5`](https://togithub.com/googleapis/java-bigquery/blob/HEAD/CHANGELOG.md#2145-httpsgithubcomgoogleapisjava-bigquerycomparev2144v2145-2022-08-12) [Compare Source](https://togithub.com/googleapis/java-bigquery/compare/v2.14.4...v2.14.5) ##### Dependencies - update dependency com.google.apis:google-api-services-bigquery to v2-rev20220806-2.0.0 ([#2223](https://togithub.com/googleapis/java-bigquery/issues/2223)) ([05d1de1](https://togithub.com/googleapis/java-bigquery/commit/05d1de19488c45ceb202824d9ce2ae0fd290d930)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-asset).

🤖 I have created a release *beep* *boop* --- ## [3.6.0](googleapis/java-asset@v3.5.0...v3.6.0) (2022-09-15) ### Features * Add client library support for AssetService v1 BatchGetEffectiveIamPolicies API ([3919a1d](googleapis/java-asset@3919a1d)) * Add client library support for AssetService v1 BatchGetEffectiveIamPolicies API ([#1300](googleapis/java-asset#1300)) ([3919a1d](googleapis/java-asset@3919a1d)) * Release of query system ([3919a1d](googleapis/java-asset@3919a1d)) ### Dependencies * Update dependency com.google.api.grpc:proto-google-cloud-orgpolicy-v1 to v2.3.2 ([#1302](googleapis/java-asset#1302)) ([d01d900](googleapis/java-asset@d01d900)) * Update dependency com.google.api.grpc:proto-google-cloud-orgpolicy-v1 to v2.3.3 ([#1332](googleapis/java-asset#1332)) ([c1511c2](googleapis/java-asset@c1511c2)) * Update dependency com.google.api.grpc:proto-google-cloud-os-config-v1 to v2.5.2 ([#1309](googleapis/java-asset#1309)) ([cf96ee9](googleapis/java-asset@cf96ee9)) * Update dependency com.google.api.grpc:proto-google-cloud-pubsub-v1 to v1.102.11 ([#1297](googleapis/java-asset#1297)) ([d56eedd](googleapis/java-asset@d56eedd)) * Update dependency com.google.api.grpc:proto-google-cloud-pubsub-v1 to v1.102.12 ([#1316](googleapis/java-asset#1316)) ([a3713fd](googleapis/java-asset@a3713fd)) * Update dependency com.google.api.grpc:proto-google-cloud-pubsub-v1 to v1.102.13 ([#1321](googleapis/java-asset#1321)) ([883b7b8](googleapis/java-asset@883b7b8)) * Update dependency com.google.api.grpc:proto-google-cloud-pubsub-v1 to v1.102.14 ([#1334](googleapis/java-asset#1334)) ([56cb4b4](googleapis/java-asset@56cb4b4)) * Update dependency com.google.api.grpc:proto-google-identity-accesscontextmanager-v1 to v1.4.1 ([#1307](googleapis/java-asset#1307)) ([b90baf7](googleapis/java-asset@b90baf7)) * Update dependency com.google.cloud:google-cloud-bigquery to v2.14.4 ([#1301](googleapis/java-asset#1301)) ([64f7ea5](googleapis/java-asset@64f7ea5)) * Update dependency com.google.cloud:google-cloud-bigquery to v2.14.6 ([#1315](googleapis/java-asset#1315)) ([fa179e2](googleapis/java-asset@fa179e2)) * Update dependency com.google.cloud:google-cloud-bigquery to v2.14.7 ([#1320](googleapis/java-asset#1320)) ([06d1a16](googleapis/java-asset@06d1a16)) * Update dependency com.google.cloud:google-cloud-bigquery to v2.15.0 ([#1326](googleapis/java-asset#1326)) ([df36595](googleapis/java-asset@df36595)) * Update dependency com.google.cloud:google-cloud-bigquery to v2.16.0 ([#1336](googleapis/java-asset#1336)) ([870779d](googleapis/java-asset@870779d)) * Update dependency com.google.cloud:google-cloud-core to v2.8.10 ([#1323](googleapis/java-asset#1323)) ([09e03b8](googleapis/java-asset@09e03b8)) * Update dependency com.google.cloud:google-cloud-core to v2.8.11 ([#1331](googleapis/java-asset#1331)) ([a112cec](googleapis/java-asset@a112cec)) * Update dependency com.google.cloud:google-cloud-core to v2.8.9 ([#1314](googleapis/java-asset#1314)) ([8edc2b8](googleapis/java-asset@8edc2b8)) * Update dependency com.google.cloud:google-cloud-pubsub to v1.120.11 ([#1298](googleapis/java-asset#1298)) ([172b34b](googleapis/java-asset@172b34b)) * Update dependency com.google.cloud:google-cloud-pubsub to v1.120.12 ([#1317](googleapis/java-asset#1317)) ([1ea636f](googleapis/java-asset@1ea636f)) * Update dependency com.google.cloud:google-cloud-pubsub to v1.120.13 ([#1322](googleapis/java-asset#1322)) ([b7522b9](googleapis/java-asset@b7522b9)) * Update dependency com.google.cloud:google-cloud-pubsub to v1.120.14 ([#1335](googleapis/java-asset#1335)) ([e9142b4](googleapis/java-asset@e9142b4)) * Update dependency com.google.cloud:google-cloud-resourcemanager to v1.5.3 ([#1318](googleapis/java-asset#1318)) ([aa3a1bb](googleapis/java-asset@aa3a1bb)) * Update dependency com.google.cloud:google-cloud-resourcemanager to v1.5.4 ([#1328](googleapis/java-asset#1328)) ([fca0ce5](googleapis/java-asset@fca0ce5)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.2 ([#1330](googleapis/java-asset#1330)) ([ccb704c](googleapis/java-asset@ccb704c)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.3 ([#1340](googleapis/java-asset#1340)) ([0d87a9d](googleapis/java-asset@0d87a9d)) * Update dependency com.google.cloud:google-cloud-storage to v2.11.3 ([#1299](googleapis/java-asset#1299)) ([d59e6c6](googleapis/java-asset@d59e6c6)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

* bugfix: make exception for non-cloud artifacts * change format Source-Link: googleapis/synthtool@a86e189 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:944c07e458ce227ca49a423affedf088e31e2ee70908dd21682238d58f1beb60 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

mziccard added 2 commits October 13, 2016 14:31

Rename setters/getters/builders for Datastore classes to meet proto c…

c1deb59

…onventions

Update Datastore examples, snippets and READMEs to use renamed getter…

b7a5c2f

…s/setters/builders

mziccard added the api: datastore Issues related to the Datastore API. label Oct 13, 2016

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 13, 2016

lesv reviewed Oct 13, 2016

View reviewed changes

google-cloud-datastore/src/main/java/com/google/cloud/datastore/IncompleteKey.java

*/

@Override

@Deprecated

public Key parent() {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

lesv reviewed Oct 13, 2016

View reviewed changes

lesv approved these changes Oct 13, 2016

View reviewed changes

Make deprecated methods call renamed ones

5e99922

mziccard merged commit 7bcfe3e into googleapis:master Oct 20, 2016

release-please bot mentioned this pull request Aug 24, 2022

chore: release monorepo_script_output #8199

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rename setters/getters/builders for Datastore classes to meet proto conventions #1315

Rename setters/getters/builders for Datastore classes to meet proto conventions #1315

Uh oh!

mziccard commented Oct 13, 2016

Uh oh!

coveralls commented Oct 13, 2016

Uh oh!

mziccard commented Oct 13, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

lesv left a comment

Uh oh!

coveralls commented Oct 14, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Rename setters/getters/builders for Datastore classes to meet proto conventions #1315

Rename setters/getters/builders for Datastore classes to meet proto conventions #1315

Uh oh!

Conversation

mziccard commented Oct 13, 2016

Uh oh!

coveralls commented Oct 13, 2016

Uh oh!

mziccard commented Oct 13, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

lesv left a comment

Choose a reason for hiding this comment

Uh oh!

coveralls commented Oct 14, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants