Fix generation of signed urls for blobs containing spaces and other special chars #1277

ostronom · 2016-09-22T08:36:19Z

As it is stated here https://cloud.google.com/storage/docs/access-control/signed-urls#about-canonical-resources:

Be sure to copy the HTTP request path literally: that is, you should include all URL encoding (percent signs) in the string that you create

Because there was no encoding of spaces, all blobs with spaces were provided with invalid signatures. This pull request fixes this.

…pecial chars

coveralls · 2016-09-22T08:51:49Z

Coverage remained the same at 84.603% when pulling a4d75e9 on ostronom:master into 05a2a32 on GoogleCloudPlatform:master.

mziccard · 2016-09-22T11:57:33Z

@ostronom thanks for doing this! Incredibly, we seem to have missed this for a very long time.

What about adding a test for a blob name that needs encoding? I can do it myself if don't have time :)

coveralls · 2016-09-22T13:47:47Z

Coverage remained the same at 84.603% when pulling cd7e858 on ostronom:master into 05a2a32 on GoogleCloudPlatform:master.

ostronom · 2016-09-22T13:49:32Z

I've added test for this. Fortunately, it is passing :)

google-cloud-storage/src/test/java/com/google/cloud/storage/StorageImplTest.java

        URLDecoder.decode(signature, UTF_8.name()))));
  }

+  @Test


mziccard · 2016-09-22T14:04:15Z

@ostronom Great job! Just a minor annoying comment about formatting :)

google-cloud-storage/src/test/java/com/google/cloud/storage/StorageImplTest.java

-    // List of chars under test were taken from https://en.wikipedia.org/wiki/Percent-encoding#Percent-encoding_reserved_characters
-    char[] specialChars = new char[]{'!','#','$','&','\'','(',')','*','+',',',':',';','=','?','@','[',']'};
+  public void testSignUrlForBlobWithSpecialChars() throws NoSuchAlgorithmException,
+          InvalidKeyException, SignatureException, UnsupportedEncodingException {


coveralls · 2016-09-22T14:26:17Z

Coverage remained the same at 84.603% when pulling 66b83a0 on ostronom:master into 05a2a32 on GoogleCloudPlatform:master.

coveralls · 2016-09-22T14:36:50Z

Coverage remained the same at 84.603% when pulling 66b83a0 on ostronom:master into 05a2a32 on GoogleCloudPlatform:master.

🤖 I have created a release *beep* *boop* --- ## [3.5.0](googleapis/java-asset@v3.4.2...v3.5.0) (2022-08-09) ### Features * Remove v1p4beta1 API protos. v1p4beta1 has been deprecated and announced through MSA. This is the cleanup ([ebab5c6](googleapis/java-asset@ebab5c6)) ### Dependencies * update dependency com.google.api.grpc:proto-google-cloud-orgpolicy-v1 to v2.3.0 ([#1257](googleapis/java-asset#1257)) ([c61c0e8](googleapis/java-asset@c61c0e8)) * update dependency com.google.api.grpc:proto-google-cloud-os-config-v1 to v2.5.1 ([#1279](googleapis/java-asset#1279)) ([5995764](googleapis/java-asset@5995764)) * update dependency com.google.api.grpc:proto-google-cloud-pubsub-v1 to v1.102.10 ([#1292](googleapis/java-asset#1292)) ([76f886e](googleapis/java-asset@76f886e)) * update dependency com.google.api.grpc:proto-google-cloud-pubsub-v1 to v1.102.9 ([#1280](googleapis/java-asset#1280)) ([a35d490](googleapis/java-asset@a35d490)) * update dependency com.google.cloud:google-cloud-bigquery to v2.14.0 ([#1272](googleapis/java-asset#1272)) ([60763d4](googleapis/java-asset@60763d4)) * update dependency com.google.cloud:google-cloud-bigquery to v2.14.1 ([#1274](googleapis/java-asset#1274)) ([8b4efa5](googleapis/java-asset@8b4efa5)) * update dependency com.google.cloud:google-cloud-bigquery to v2.14.2 ([#1294](googleapis/java-asset#1294)) ([ff76d3a](googleapis/java-asset@ff76d3a)) * update dependency com.google.cloud:google-cloud-bigquery to v2.14.3 ([#1296](googleapis/java-asset#1296)) ([4c2a6ec](googleapis/java-asset@4c2a6ec)) * update dependency com.google.cloud:google-cloud-core to v2.8.3 ([#1273](googleapis/java-asset#1273)) ([1ad7821](googleapis/java-asset@1ad7821)) * update dependency com.google.cloud:google-cloud-core to v2.8.4 ([#1275](googleapis/java-asset#1275)) ([a45d90c](googleapis/java-asset@a45d90c)) * update dependency com.google.cloud:google-cloud-core to v2.8.5 ([#1276](googleapis/java-asset#1276)) ([985d6e6](googleapis/java-asset@985d6e6)) * update dependency com.google.cloud:google-cloud-core to v2.8.6 ([#1283](googleapis/java-asset#1283)) ([26f527c](googleapis/java-asset@26f527c)) * update dependency com.google.cloud:google-cloud-core to v2.8.7 ([#1285](googleapis/java-asset#1285)) ([fe40190](googleapis/java-asset@fe40190)) * update dependency com.google.cloud:google-cloud-core to v2.8.8 ([#1288](googleapis/java-asset#1288)) ([566e032](googleapis/java-asset@566e032)) * update dependency com.google.cloud:google-cloud-pubsub to v1.120.1 ([#1229](googleapis/java-asset#1229)) ([dcc463c](googleapis/java-asset@dcc463c)) * update dependency com.google.cloud:google-cloud-pubsub to v1.120.10 ([#1293](googleapis/java-asset#1293)) ([d6188ca](googleapis/java-asset@d6188ca)) * update dependency com.google.cloud:google-cloud-pubsub to v1.120.9 ([#1281](googleapis/java-asset#1281)) ([79d5a3c](googleapis/java-asset@79d5a3c)) * update dependency com.google.cloud:google-cloud-resourcemanager to v1.5.0 ([#1261](googleapis/java-asset#1261)) ([1cca78c](googleapis/java-asset@1cca78c)) * update dependency com.google.cloud:google-cloud-resourcemanager to v1.5.2 ([#1287](googleapis/java-asset#1287)) ([a399744](googleapis/java-asset@a399744)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v3 ([#1277](googleapis/java-asset#1277)) ([7a27f49](googleapis/java-asset@7a27f49)) * update dependency com.google.cloud:google-cloud-storage to v2.10.0 ([#1282](googleapis/java-asset#1282)) ([66ba2ad](googleapis/java-asset@66ba2ad)) * update dependency com.google.cloud:google-cloud-storage to v2.11.0 ([#1286](googleapis/java-asset#1286)) ([4df8988](googleapis/java-asset@4df8988)) * update dependency com.google.cloud:google-cloud-storage to v2.11.1 ([#1291](googleapis/java-asset#1291)) ([3af9102](googleapis/java-asset@3af9102)) * update dependency com.google.cloud:google-cloud-storage to v2.11.2 ([#1295](googleapis/java-asset#1295)) ([693d42b](googleapis/java-asset@693d42b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

…p/templates/java_library/.kokoro (#1761) (#1277) * build(deps): bump cryptography Bumps [cryptography](https://github.com/pyca/cryptography) from 38.0.3 to 39.0.1. - [Release notes](https://github.com/pyca/cryptography/releases) - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@38.0.3...39.0.1) --- updated-dependencies: - dependency-name: cryptography dependency-type: indirect ... * chore: disabling dependabot --------- Source-Link: googleapis/synthtool@0c6f8d4 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:5ee35ee919254a3d1e7d4f8abbf1b8c8869ade317ceb2e4df709af1b4b3e9ca1 Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Tomo Suzuki <suztomo@google.com> Co-authored-by: ddixit14 <deepankardixit@google.com>

Fix generation of signed urls for blobs containing spaces and other s…

a4d75e9

…pecial chars

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 22, 2016

Added test for special characters in url signing

cd7e858

mziccard reviewed Sep 22, 2016

View reviewed changes

google-cloud-storage/src/test/java/com/google/cloud/storage/StorageImplTest.java

URLDecoder.decode(signature, UTF_8.name()))));

}

@Test

This comment was marked as spam.

Sign in to view

Formatting rules applied

35daa5c

mziccard reviewed Sep 22, 2016

View reviewed changes

Remove extra spaces

66b83a0

mziccard merged commit ac786de into googleapis:master Sep 22, 2016

mickeyreiss mentioned this pull request Oct 28, 2016

Regression in storage url signing #1346

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix generation of signed urls for blobs containing spaces and other special chars #1277

Fix generation of signed urls for blobs containing spaces and other special chars #1277

Uh oh!

ostronom commented Sep 22, 2016

Uh oh!

coveralls commented Sep 22, 2016

Uh oh!

mziccard commented Sep 22, 2016

Uh oh!

coveralls commented Sep 22, 2016

Uh oh!

ostronom commented Sep 22, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

mziccard commented Sep 22, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

coveralls commented Sep 22, 2016

Uh oh!

coveralls commented Sep 22, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Fix generation of signed urls for blobs containing spaces and other special chars #1277

Fix generation of signed urls for blobs containing spaces and other special chars #1277

Uh oh!

Conversation

ostronom commented Sep 22, 2016

Uh oh!

coveralls commented Sep 22, 2016

Uh oh!

mziccard commented Sep 22, 2016

Uh oh!

coveralls commented Sep 22, 2016

Uh oh!

ostronom commented Sep 22, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

mziccard commented Sep 22, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

coveralls commented Sep 22, 2016

Uh oh!

coveralls commented Sep 22, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants