Skip to content

Conversation

@mziccard
Copy link
Contributor

This fixes #1112

@mziccard mziccard added the api: datastore Issues related to the Datastore API. label Sep 12, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 12, 2016
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 84.96% when pulling 64e95b8 on mziccard:datastore-serializable into 4d5a86c on GoogleCloudPlatform:master.

@mziccard
Copy link
Contributor Author

This removes Datastore's Serializable class (as I mentioned this some time ago). Other than that this PR also:

  • Implements toString on a per-class basis without relying on toPb
  • Removes to/fromPb methods that are not needed
  • Fixes some minor style issues

@aozarov your opinion would be valuable in this

*/
public abstract class BaseEntity<K extends IncompleteKey>
extends Serializable<com.google.datastore.v1.Entity> {
public abstract class BaseEntity<K extends IncompleteKey> implements java.io.Serializable {

This comment was marked as spam.

@aozarov
Copy link
Contributor

aozarov commented Sep 12, 2016

LGTM

@mziccard mziccard force-pushed the datastore-serializable branch from 64e95b8 to 5f7d381 Compare September 13, 2016 06:54
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 5f7d381 on mziccard:datastore-serializable into * on GoogleCloudPlatform:master*.

@mziccard mziccard merged commit 9c840d6 into googleapis:master Sep 13, 2016
github-actions bot pushed a commit that referenced this pull request Sep 15, 2022
…16.0 (#1240)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:google-cloud-bigquery](https://togithub.com/googleapis/java-bigquery) | `2.15.0` -> `2.16.0` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-bigquery/2.16.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-bigquery/2.16.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-bigquery/2.16.0/compatibility-slim/2.15.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-bigquery/2.16.0/confidence-slim/2.15.0)](https://docs.renovatebot.com/merge-confidence/) |

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-automl).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xOTQuNSIsInVwZGF0ZWRJblZlciI6IjMyLjE5NC41In0=-->
github-actions bot pushed a commit that referenced this pull request Sep 15, 2022
🤖 I have created a release *beep* *boop*
---


## [2.3.9](googleapis/java-automl@v2.3.8...v2.3.9) (2022-09-13)


### Dependencies

* Update dependency com.google.cloud:google-cloud-bigquery to v2.16.0 ([#1240](googleapis/java-automl#1240)) ([1dc7d55](googleapis/java-automl@1dc7d55))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
meltsufin pushed a commit that referenced this pull request Dec 22, 2025
…to v3.14.0 (#1240)

* chore(deps): update dependency com.google.cloud:google-cloud-logging to v3.14.0

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: datastore Issues related to the Datastore API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

remove newlines from datastore Key.toString() values

4 participants