fix!: [discoveryengine] http_uri fix for method ListChunks in service ChunkService#10508
Closed
gcf-owl-bot[bot] wants to merge 12 commits into
Closed
fix!: [discoveryengine] http_uri fix for method ListChunks in service ChunkService#10508gcf-owl-bot[bot] wants to merge 12 commits into
http_uri fix for method ListChunks in service ChunkService#10508gcf-owl-bot[bot] wants to merge 12 commits into
Conversation
feat: support boost in multi-turn search feat: add document processing config services feat: add search tuning services feat: allow setting schema on schema creation docs: keep the API doc up-to-date with recent changes PiperOrigin-RevId: 614046598 Source-Link: googleapis/googleapis@d66613f Source-Link: https://github.com/googleapis/googleapis-gen/commit/3d656450d3a676ceab7078c673f2e05243e01d8f Copy-Tag: eyJwIjoiamF2YS1kaXNjb3ZlcnllbmdpbmUvLk93bEJvdC55YW1sIiwiaCI6IjNkNjU2NDUwZDNhNjc2Y2VhYjcwNzhjNjczZjJlMDUyNDNlMDFkOGYifQ==
trusted-contributions-gcf
Bot
added
kokoro:force-run
gcf-owl-bot
Bot
removed
the
owlbot:run
yoshi-kokoro
removed
the
kokoro:force-run
trusted-contributions-gcf
Bot
added
kokoro:force-run
gcf-owl-bot
Bot
removed
the
owlbot:run
yoshi-kokoro
removed
the
kokoro:force-run
…m/googleapis/google-cloud-java into owl-bot-copy-java-discoveryengine
trusted-contributions-gcf
Bot
added
kokoro:force-run
gcf-owl-bot
Bot
removed
the
owlbot:run
yoshi-kokoro
removed
the
kokoro:force-run
feat: support chunk-based document search feat: support search adaptor based search feat: support batch documents purge with GCS input feat: add document processing config services feat: add serving config services feat: add billing estimation services feat: add suggestion deny list import/purge services docs: keep the API doc up-to-date with recent changes PiperOrigin-RevId: 614160461 Source-Link: googleapis/googleapis@b553626 Source-Link: https://github.com/googleapis/googleapis-gen/commit/4394e3704d4d04697ef54d16ffb7d5057ab3a2fe Copy-Tag: eyJwIjoiamF2YS1kaXNjb3ZlcnllbmdpbmUvLk93bEJvdC55YW1sIiwiaCI6IjQzOTRlMzcwNGQ0ZDA0Njk3ZWY1NGQxNmZmYjdkNTA1N2FiM2EyZmUifQ==
gcf-owl-bot
Bot
changed the title
trusted-contributions-gcf
Bot
added
kokoro:force-run
gcf-owl-bot
Bot
removed
the
owlbot:run
yoshi-kokoro
removed
the
kokoro:force-run
trusted-contributions-gcf
Bot
added
kokoro:force-run
gcf-owl-bot
Bot
removed
the
owlbot:run
yoshi-kokoro
removed
the
kokoro:force-run
trusted-contributions-gcf
Bot
added
kokoro:force-run
gcf-owl-bot
Bot
removed
the
owlbot:run
yoshi-kokoro
removed
kokoro:force-run
parthea
reviewed
Mar 9, 2024
| mockService.addResponse(expectedResponse); | ||
|
|
||
| String parent = | ||
| "projects/project-3187/locations/location-3187/dataStores/dataStore-3187/branches/branche-3187"; |
Contributor
There was a problem hiding this comment.
There may be an issue with the parent path where part of the segment is missing as the rpc ListChunks has "/v1alpha/{parent=projects/*/locations/*/dataStores/*/branches/*}/documents/*/chunks" instead of "/v1alpha/{parent=projects/*/locations/*/dataStores/*/branches/*/documents/*}/chunks"
This is also causing an issue for python client library generation. See googleapis/google-cloud-python#12433 (comment)
Googlers see b/328843326 and b/328869136
diegomarquezp
added
the
do not merge
Contributor
|
We will use #10503 once it's merged for all library source code changes |
PiperOrigin-RevId: 614683212 Source-Link: googleapis/googleapis@716a939 Source-Link: https://github.com/googleapis/googleapis-gen/commit/a54c0126868455148c339ce88209dca049e84171 Copy-Tag: eyJwIjoiamF2YS1kaXNjb3ZlcnllbmdpbmUvLk93bEJvdC55YW1sIiwiaCI6ImE1NGMwMTI2ODY4NDU1MTQ4YzMzOWNlODgyMDlkY2EwNDllODQxNzEifQ==
gcf-owl-bot
Bot
changed the title
http_uri fix for method ListChunks in service ChunkService
trusted-contributions-gcf
Bot
added
kokoro:force-run
gcf-owl-bot
Bot
removed
the
owlbot:run
yoshi-kokoro
removed
the
kokoro:force-run
trusted-contributions-gcf
Bot
added
kokoro:force-run
gcf-owl-bot
Bot
removed
the
owlbot:run
yoshi-kokoro
removed
the
kokoro:force-run
trusted-contributions-gcf
Bot
added
kokoro:force-run
gcf-owl-bot
Bot
removed
the
owlbot:run
yoshi-kokoro
removed
the
kokoro:force-run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PiperOrigin-RevId: 614683212
Source-Link: googleapis/googleapis@716a939
Source-Link: https://github.com/googleapis/googleapis-gen/commit/a54c0126868455148c339ce88209dca049e84171
Copy-Tag: eyJwIjoiamF2YS1kaXNjb3ZlcnllbmdpbmUvLk93bEJvdC55YW1sIiwiaCI6ImE1NGMwMTI2ODY4NDU1MTQ4YzMzOWNlODgyMDlkY2EwNDllODQxNzEifQ==
BEGIN_NESTED_COMMIT
feat: [discoveryengine] support acl-based and blended search
feat: support chunk-based document search
feat: support search adaptor based search
feat: support batch documents purge with GCS input
feat: add document processing config services
feat: add serving config services
feat: add billing estimation services
feat: add suggestion deny list import/purge services
docs: keep the API doc up-to-date with recent changes
PiperOrigin-RevId: 614160461
Source-Link: googleapis/googleapis@b553626
Source-Link: https://github.com/googleapis/googleapis-gen/commit/4394e3704d4d04697ef54d16ffb7d5057ab3a2fe
Copy-Tag: eyJwIjoiamF2YS1kaXNjb3ZlcnllbmdpbmUvLk93bEJvdC55YW1sIiwiaCI6IjQzOTRlMzcwNGQ0ZDA0Njk3ZWY1NGQxNmZmYjdkNTA1N2FiM2EyZmUifQ==
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: [discoveryengine] support blended search
feat: support boost in multi-turn search
feat: add document processing config services
feat: add search tuning services
feat: allow setting schema on schema creation
docs: keep the API doc up-to-date with recent changes
PiperOrigin-RevId: 614046598
Source-Link: googleapis/googleapis@d66613f
Source-Link: https://github.com/googleapis/googleapis-gen/commit/3d656450d3a676ceab7078c673f2e05243e01d8f
Copy-Tag: eyJwIjoiamF2YS1kaXNjb3ZlcnllbmdpbmUvLk93bEJvdC55YW1sIiwiaCI6IjNkNjU2NDUwZDNhNjc2Y2VhYjcwNzhjNjczZjJlMDUyNDNlMDFkOGYifQ==
END_NESTED_COMMIT