[sdk-platform-java] Generate native image reflect-config.json for com.google.firestore.bundle #12481

Activity

1. mpeddada1

   added

   type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

   on Sep 19, 2023
2. lqiu96

   added

   priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.

   on Sep 20, 2023
3. blakeli0 commented on Sep 20, 2023

   

   blakeli0

   on Sep 20, 2023

   Last edited by blakeli0

   Contributor

   More actions

   Do we know how the com.google.firestore.bundle classes are added to java-firestore repo? I don't see them being passed into the generator in the Bazel build file.
4. mpeddada1 commented on Sep 20, 2023

   

   mpeddada1

   on Sep 20, 2023

   ContributorAuthor

   More actions

   The bazel rule for assembling this code is located under the google/firestore/bundle directory. Originally, it looks like this package was manually generated (googleapis/java-firestore#271) in the repo and then the bazel rules were migrated over to third_party?
5. blakeli0 commented on Sep 21, 2023

   

   blakeli0

   on Sep 21, 2023

   Contributor

   More actions

   I see, this is a proto only module that does not involve the generator, it is generated using protoc plugin directly. If that's the case, I don't think we have a way to generate it through generator.
   Is this the only occurrence of this issue? Do you see it happening in other handwritten libraries?
6. mpeddada1 commented on Sep 27, 2023

   

   mpeddada1

   on Sep 27, 2023

   Last edited by mpeddada1

   ContributorAuthor

   More actions

   Hm I could be wrong but these classes seem to get generator updates through Owlbot (example, googleapis/java-firestore#1304) which make me think that they aren't fully disconnected?

   Is this the only occurrence of this issue? Do you see it happening in other handwritten libraries?

   From what we've observed so far, Firestore is the only one that has this issue. From the native image perspective, Spanner needed manually added configs but for different reason as there were explicitly using + reflectively calling some com.google.rpc classes (googleapis/java-spanner#2617)
7. blakeli0

   added

   type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.‘Nice-to-have’ improvement, new feature or different behavior or design.

   and removed

   type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

   on Dec 19, 2023
8. blakeli0 commented on Dec 19, 2023

   

   blakeli0

   on Dec 19, 2023

   Contributor

   More actions

   Hm I could be wrong but these classes seem to get generator updates through Owlbot (example, googleapis/java-firestore#1304) which make me think that they aren't fully disconnected?

   Yes they are generated into googleapis-gen through the Bazel configurations , hence we can configure owlbot to copy the code from googleapis-gen. But the Bazel configurations only include firestore_bundle_java_proto and firestore_bundle_proto, which do not go through the gapic-generator-java code, compare to a firestore v1 Bazel configuration, that includes a firestore_java_gapic dependency.

   This issue suffers from the same root cause as I mentioned in #12478, if we do prioritize these issues, I would suggest to fix #12478 first.
9. chingor13

   changed the title [-]Generate native image reflect-config.json for com.google.firestore.bundle[/-] [+][sdk-platform-java] Generate native image reflect-config.json for com.google.firestore.bundle[/+] on Apr 1, 2026
10. chingor13

    transferred this issue fromgoogleapis/sdk-platform-javaon Apr 1, 2026