Skip to content
This repository was archived by the owner on Dec 8, 2021. It is now read-only.

Conversation

@coryan
Copy link
Contributor

@coryan coryan commented Oct 8, 2019

The documentation on how to create a release for this repo needed a review too.


This change is Reviewable

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 8, 2019
@codecov
Copy link

codecov bot commented Oct 8, 2019

Codecov Report

Merging #37 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #37   +/-   ##
======================================
  Coverage    92.6%   92.6%           
======================================
  Files          53      53           
  Lines        1311    1311           
======================================
  Hits         1214    1214           
  Misses         97      97

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 454195f...34d316b. Read the comment docs.

@coryan coryan marked this pull request as ready for review October 9, 2019 13:44
@coryan coryan changed the title doc: prepare release notes (and docs) for 1.0 release. doc: prepare release notes (and docs) for 0.13.0 release. Oct 9, 2019
@coryan
Copy link
Contributor Author

coryan commented Oct 9, 2019

I am creating a release for google-cloud-cpp-common. At first I thought it would be 1.0, but I think maybe we want to change the namespaces a bit (see #39).

@mr-salty
Copy link
Contributor

mr-salty commented Oct 9, 2019

why not 1.0? I thought that was a good idea since the code in here is already effectively GA, and when we point our already GA projects at it (BT/GCS), it seems like their dependencies should also be GA.... although I have no real objection to waiting to make this 1.0 until we're ready to do the latter if that's your plan.

@mr-salty
Copy link
Contributor

mr-salty commented Oct 9, 2019

oh, I guess I was wrong about 'common' previously having a GA version number... which does seem odd (1.x depending on 0.x).

Copy link
Contributor

@mr-salty mr-salty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

FWIW, we should probably try to "refactor" cutting-a-release into some common instructions for all our repos and have the repo-specific ones just point there. Always a bit trickier than refactoring code but there's a lot of duplication.

Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @devbww, @devjgm, @mr-salty, and @scotthart)

@coryan coryan merged commit acd2efa into googleapis:master Oct 9, 2019
@coryan coryan deleted the update-release-notes branch October 9, 2019 17:27
coryan added a commit to coryan/google-cloud-cpp that referenced this pull request Apr 24, 2020
coryan added a commit to coryan/google-cloud-cpp that referenced this pull request Apr 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants