Skip to content

chore(compute): regenerate ssl_policies stubs - #16657

Open
wcornell wants to merge 1 commit into
googleapis:mainfrom
wcornell:fix-rest-path-encoding
Open

chore(compute): regenerate ssl_policies stubs#16657
wcornell wants to merge 1 commit into
googleapis:mainfrom
wcornell:fix-rest-path-encoding

Conversation

@wcornell

@wcornell wcornell commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@product-auto-label product-auto-label Bot added the api: compute Issues related to the Compute Engine API. label Nov 11, 2026
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Nov 11, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors DefaultRegionSslPoliciesRestStub and DefaultSslPoliciesRestStub to use rest_internal::EncodePath instead of absl::StrCat for constructing request paths in GetIamPolicy, SetIamPolicy, and TestIamPermissions. It also introduces proper error handling by checking the status of the generated path before making the REST calls. There are no review comments to evaluate, and I have no further feedback to provide as the changes are correct and improve robustness.

@codecov

codecov Bot commented Nov 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.61%. Comparing base (bbe5b43) to head (c9c5a34).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #16657      +/-   ##
==========================================
- Coverage   92.61%   92.61%   -0.01%     
==========================================
  Files        2271     2271              
  Lines      224134   224134              
==========================================
- Hits       207583   207578       -5     
- Misses      16551    16556       +5

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wcornell
wcornell marked this pull request as ready for review November 12, 2026 00:03
@wcornell
wcornell requested a review from a team as a code owner November 12, 2026 00:03
@wcornell
wcornell enabled auto-merge (squash) November 12, 2026 00:05

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

api: compute Issues related to the Compute Engine API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@wcornell