Skip to content

feat(designcenter): generate library - #16641

Open
colinmoy wants to merge 1 commit into
googleapis:mainfrom
colinmoy:feat-designcenter-generate-library
Open

feat(designcenter): generate library#16641
colinmoy wants to merge 1 commit into
googleapis:mainfrom
colinmoy:feat-designcenter-generate-library

Conversation

@colinmoy

@colinmoy colinmoy commented Nov 9, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@colinmoy
colinmoy requested a review from a team as a code owner November 9, 2026 23:07
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Nov 9, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new GA C++ client library for the Google Cloud Design Center API, complete with generated client, connection, stub, tracing, logging, and metadata decorator implementations, as well as build configurations and a quickstart sample. Feedback on the quickstart sample highlights a style guide violation where auto is used to deduce a StatusOr type in a loop; it is recommended to explicitly type the loop variable as a reference to google::cloud::StatusOr<google::cloud::designcenter::v1::Space> to avoid obscuring the domain type and prevent unnecessary copies.

Comment thread google/cloud/designcenter/quickstart/quickstart.cc Resolved
@colinmoy
colinmoy force-pushed the feat-designcenter-generate-library branch from 35c9197 to 20342c3 Compare November 9, 2026 23:23
@codecov

codecov Bot commented Nov 10, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.52%. Comparing base (b32a1f5) to head (3ac68cc).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #16641   +/-   ##
=======================================
  Coverage   92.51%   92.52%           
=======================================
  Files        2269     2269           
  Lines      222804   222804           
=======================================
+ Hits       206126   206140   +14     
+ Misses      16678    16664   -14

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@colinmoy
colinmoy force-pushed the feat-designcenter-generate-library branch from 20342c3 to 3ac68cc Compare November 10, 2026 20:37
@colinmoy
colinmoy enabled auto-merge (squash) November 10, 2026 21:59

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@colinmoy