fix(storage): limit retries in InsertObjectWithBadChecksum sample - #16322
Merged
v-pratap merged 2 commits intoAug 5, 2026
Conversation
product-auto-label
Bot
added
api: storage
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the InsertObjectWithBadChecksum example to set a custom retry policy with a limited error count. The feedback suggests using std::make_shared directly to instantiate the retry policy instead of creating a temporary object and calling .clone(), which avoids unnecessary heap allocation and copying.
kalragauri
approved these changes
Aug 5, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16322 +/- ##
==========================================
- Coverage 92.25% 92.24% -0.02%
==========================================
Files 2227 2227
Lines 209234 209234
==========================================
- Hits 193024 193001 -23
- Misses 16210 16233 +23 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
InsertObjectWithBadChecksum,client.InsertObjectwas called without limiting retries. When executed in CI against the gRPC emulator, checksum errors over gRPC return retryable error statuses, causing the operation to retry until the default 15-minuteLimitedTimeRetryPolicyexpires and timing out the test target (//google/cloud/storage/examples:storage_object_samples).This PR adds
.set<gcs::RetryPolicyOption>(gcs::LimitedErrorCountRetryPolicy(2).clone())to the per-call options inInsertObjectWithBadChecksum. This ensures the operation fails after 2 retries and returns immediately.