Skip to content

feat(storage): migrate sync client to unified checksum options - #16264

Merged
v-pratap merged 9 commits into
googleapis:mainfrom
v-pratap:unified-checksum-options-pr3
Jul 28, 2026
Merged

feat(storage): migrate sync client to unified checksum options#16264
v-pratap merged 9 commits into
googleapis:mainfrom
v-pratap:unified-checksum-options-pr3

Conversation

@v-pratap

@v-pratap v-pratap commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Migrates the Sync client to use the newly introduced unified checksum options. Also includes the necessary fallback logic to support users who are still using the deprecated options.

Note: This PR is stacked on top of #16261 and includes its commits. It should be merged after #16261.

@v-pratap
v-pratap requested review from a team as code owners July 16, 2026 13:15
@product-auto-label product-auto-label Bot added the api: storage Issues related to the Cloud Storage API. label Jul 16, 2026
@v-pratap v-pratap added the do not review Indicates a PR is not ready for review label Jul 16, 2026
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Jul 16, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces UploadChecksumValidationOption and DownloadChecksumValidationOption using a new ChecksumAlgorithm enum to replace several deprecated checksum options and classes. It updates internal hash functions, validators, and tests to support these new options. The review feedback highlights that using the deprecated types in hash_function.cc, hash_validator.cc, and object_requests.cc will trigger -Wdeprecated-declarations compiler warnings, suggesting the inclusion of deprecation warning disable headers. Additionally, the reviewer recommends refactoring duplicated fallback logic for resolving checksum settings into a shared helper function to align with the repository style guide.

Comment thread google/cloud/storage/internal/hash_function.cc Outdated
Comment thread google/cloud/storage/internal/hash_validator.cc Outdated
Comment thread google/cloud/storage/internal/object_requests.cc Outdated
Comment thread google/cloud/storage/internal/hash_function.cc Outdated
@codecov

codecov Bot commented Jul 16, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.58657% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.29%. Comparing base (f0c5fb2) to head (cb0d105).

Files with missing lines Patch % Lines
google/cloud/storage/client_object_test.cc 96.07% 4 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff            @@
##             main   #16264    +/-   ##
========================================
  Coverage   92.29%   92.29%            
========================================
  Files        2221     2223     +2     
  Lines      207384   207569   +185     
========================================
+ Hits       191402   191582   +180     
- Misses      15982    15987     +5

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@v-pratap
v-pratap force-pushed the unified-checksum-options-pr3 branch from d2b9add to 68aaf3e Compare July 17, 2026 05:58
v-pratap added a commit to v-pratap/google-cloud-cpp that referenced this pull request Jul 17, 2026
@v-pratap
Address review comments for PR googleapis#16264
eae7fbf
v-pratap added a commit to v-pratap/google-cloud-cpp that referenced this pull request Jul 17, 2026
@v-pratap
Address review comments for PR googleapis#16264
59e1bf1
@v-pratap
v-pratap force-pushed the unified-checksum-options-pr3 branch from eae7fbf to 59e1bf1 Compare July 17, 2026 08:53
v-pratap added a commit to v-pratap/google-cloud-cpp that referenced this pull request Jul 20, 2026
@v-pratap
Address review comments for PR googleapis#16264
d26f4af
@v-pratap
v-pratap force-pushed the unified-checksum-options-pr3 branch 3 times, most recently from 163523d to 530f38b Compare July 20, 2026 14:25
@v-pratap v-pratap removed the do not review Indicates a PR is not ready for review label Jul 20, 2026
kalragauri
kalragauri reviewed Jul 27, 2026
View reviewed changes
Comment thread google/cloud/storage/internal/checksum_helpers.h
Comment thread google/cloud/storage/client_object_test.cc
Comment thread google/cloud/storage/internal/rest/stub.cc Outdated
Comment thread google/cloud/storage/internal/hash_function.h Outdated
@v-pratap
v-pratap force-pushed the unified-checksum-options-pr3 branch from 2c6de8d to c7928ae Compare July 27, 2026 08:57
@v-pratap
v-pratap force-pushed the unified-checksum-options-pr3 branch from c7928ae to a96ec3a Compare July 27, 2026 09:10
@v-pratap
v-pratap force-pushed the unified-checksum-options-pr3 branch from a96ec3a to 49ae3a4 Compare July 27, 2026 09:15
@v-pratap
v-pratap force-pushed the unified-checksum-options-pr3 branch from d06e0fd to c4166a2 Compare July 27, 2026 09:56
@v-pratap
v-pratap requested a review from kalragauri July 27, 2026 10:01
kalragauri
kalragauri approved these changes Jul 27, 2026
View reviewed changes
Comment thread google/cloud/storage/internal/hash_function.h Outdated
@v-pratap
v-pratap merged commit d1c37cc into googleapis:main Jul 28, 2026
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kalragauri kalragauri kalragauri approved these changes
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: storage Issues related to the Cloud Storage API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@v-pratap @kalragauri