Skip to content

Revert "feat(storage): Add full object checksum validation for appendable uploads (#16110)" - #16244

Merged
v-pratap merged 6 commits into
googleapis:mainfrom
v-pratap:revert-pr-16110
Jul 10, 2026
Merged

Revert "feat(storage): Add full object checksum validation for appendable uploads (#16110)"#16244
v-pratap merged 6 commits into
googleapis:mainfrom
v-pratap:revert-pr-16110

Conversation

@v-pratap

@v-pratap v-pratap commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

This reverts pull request #16110.

@v-pratap
v-pratap requested review from a team as code owners July 9, 2026 13:50
@product-auto-label product-auto-label Bot added the api: storage Issues related to the Cloud Storage API. label Jul 9, 2026
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Jul 9, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request simplifies the appendable upload implementation by removing the tracking of persisted checksums (PersistedChecksums and persisted_data_checksums_) across AsyncWriterConnectionImpl and related classes, along with their associated tests. The review feedback points out an opportunity to clean up the lambda capture in connection_impl.cc by removing the unused persisted_size capture and passing the value directly from the RPC response.

Comment thread google/cloud/storage/internal/async/connection_impl.cc Outdated
@codecov

codecov Bot commented Jul 9, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 88.46154% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.26%. Comparing base (a52ae45) to head (65aa1cf).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...le/cloud/storage/internal/async/connection_impl.cc 80.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #16244      +/-   ##
==========================================
- Coverage   92.27%   92.26%   -0.01%     
==========================================
  Files        2214     2214              
  Lines      206394   206307      -87     
==========================================
- Hits       190443   190350      -93     
- Misses      15951    15957       +6

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@v-pratap
v-pratap requested a review from kalragauri July 9, 2026 19:18
kalragauri
kalragauri approved these changes Jul 10, 2026
View reviewed changes
Comment thread google/cloud/storage/async/writer_connection.h
@v-pratap
v-pratap merged commit 9ea5a9d into googleapis:main Jul 10, 2026
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kalragauri kalragauri kalragauri approved these changes
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: storage Issues related to the Cloud Storage API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@v-pratap @kalragauri