fix(bigtable): DynamicChannelPoolSizingPolicyOption used correctly - #16188
Conversation
There was a problem hiding this comment.
Code Review
This pull request adds support for configuring the DynamicChannelPoolSizingPolicyOption when creating a BigtableStub with the random two least used decorator. It introduces accessor methods to retrieve the channel pool and its sizing policy, along with a unit test to verify the policy propagation. The review feedback recommends returning the shared pointer by const& in pool() and using auto const& in the test to avoid unnecessary copies and atomic reference count overhead.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16188 +/- ##
==========================================
- Coverage 92.23% 92.22% -0.01%
==========================================
Files 2265 2265
Lines 209832 209875 +43
==========================================
+ Hits 193530 193564 +34
- Misses 16302 16311 +9 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
No description provided.