fix(client_library): External Authentication bug fix#15612
Draft
Khushikathuria008 wants to merge 1 commit intogoogleapis:mainfrom
Draft
fix(client_library): External Authentication bug fix#15612Khushikathuria008 wants to merge 1 commit intogoogleapis:mainfrom
Khushikathuria008 wants to merge 1 commit intogoogleapis:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does this issue affect the google-cloud-cpp project?
Yes
What component of google-cloud-cpp is this related to?
Authentication
Describe the bug
Providing an incorrect credential file causes a crash while performing external authentication.
To Reproduce Steps to reproduce the behavior:
Call ::google::cloud::MakeServiceAccountCredentials with unparsable file contents.
It will crash.
Expected behavior
There should be no crash.
This change is