perf(status): Remove MakeDefaultStatus() from Status move assignment …#15566
Open
andrewro-google wants to merge 1 commit intogoogleapis:mainfrom
Open
perf(status): Remove MakeDefaultStatus() from Status move assignment …#15566andrewro-google wants to merge 1 commit intogoogleapis:mainfrom
andrewro-google wants to merge 1 commit intogoogleapis:mainfrom
Conversation
…and construction It's a small perf hit but it does show up in profiles. In a long running query I see it taking 6% of the cpu time
andrewro-google
temporarily deployed
to
external
GitHub Actions
Inactive
Member
|
/gcbrun |
scotthart
approved these changes
Sep 29, 2025
Member
scotthart
left a comment
scotthart
left a comment
There was a problem hiding this comment.
@scotthart reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @andrewro-google)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #15566 +/- ##
=======================================
Coverage 93.04% 93.04%
=======================================
Files 2406 2406
Lines 219803 219797 -6
=======================================
+ Hits 204518 204521 +3
+ Misses 15285 15276 -9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
/gcbrun |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…and construction
It's a small perf hit but it does show up in profiles. In a long running query I see it taking 6% of the cpu time. I think the existing guarantee is stronger than it needs to be: generally no one should assume that a moved-from object has any invariants except it can be reinstantiated.
This change is