fix(core): allow BaseService#root_url to be an Addressable::URI#17895
Merged
dazuma merged 2 commits intogoogleapis:mainfrom Feb 23, 2024
nicholasdower:main
Merged
fix(core): allow BaseService#root_url to be an Addressable::URI#17895dazuma merged 2 commits intogoogleapis:mainfrom nicholasdower:main
dazuma merged 2 commits intogoogleapis:mainfrom
nicholasdower:main
Conversation
dazuma
suggested changes
Feb 21, 2024
Contributor
dazuma
left a comment
There was a problem hiding this comment.
Thanks for catching this!
dazuma
approved these changes
Feb 23, 2024
Contributor
dazuma
left a comment
There was a problem hiding this comment.
I went ahead and made the requested updates on your branch. Will merge this now. Thanks again for finding this!
Contributor
Author
|
Thanks @dazuma. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #17131. Addresses #17894.
BaseService#root_urlis documented as anAddressable::URI, but inBaseService#root_url=it is used as if it is aString. This results in the following error:The tests seem to indicate that
root_urlwas always allowed to be aStringand I don't see any code prior to #17131 which required it to be anAddressable::URI. Therefore I am proposing updating the documentation to indicate that it can be either.