feat(core): Support for universe_domain#17131
Merged
dazuma merged 1 commit intogoogleapis:mainfrom Jan 22, 2024
Merged
Conversation
bajajneha27
approved these changes
Jan 22, 2024
This was referenced Feb 20, 2024
stanhu
added a commit
to fog/fog-google
that referenced
this pull request
Jan 28, 2026
This replaces the parameter introduced in #650. universe_domain was introduced in googleapis/google-api-ruby-client#17131 and googleapis/google-auth-library-ruby#460. This is preferable because the Google Client performs some verification to ensure credentials match the cloud provider.
stanhu
added a commit
to fog/fog-google
that referenced
this pull request
Jan 28, 2026
This replaces the parameter introduced in #650. universe_domain was introduced in googleapis/google-api-ruby-client#17131 and googleapis/google-auth-library-ruby#460. This is preferable because the Google Client performs some verification to ensure credentials match the cloud provider.
stanhu
added a commit
to fog/fog-google
that referenced
this pull request
Jan 28, 2026
This replaces the parameter introduced in #650. universe_domain was introduced in googleapis/google-api-ruby-client#17131 and googleapis/google-auth-library-ruby#460. This is preferable because the Google Client performs some verification to ensure credentials match the cloud provider.
stanhu
added a commit
to fog/fog-google
that referenced
this pull request
Jan 29, 2026
This replaces the parameter introduced in #650. universe_domain was introduced in googleapis/google-api-ruby-client#17131 and googleapis/google-auth-library-ruby#460. This is preferable because the Google Client performs some verification to ensure credentials match the cloud provider.
stanhu
added a commit
to fog/fog-google
that referenced
this pull request
Jan 29, 2026
This replaces the parameter introduced in #650. universe_domain was introduced in googleapis/google-api-ruby-client#17131 and googleapis/google-auth-library-ruby#460. This is preferable because the Google Client performs some verification to ensure credentials match the cloud provider.
stanhu
added a commit
to fog/fog-google
that referenced
this pull request
Jan 29, 2026
This replaces the parameter introduced in #650. universe_domain was introduced in googleapis/google-api-ruby-client#17131 and googleapis/google-auth-library-ruby#460. This is preferable because the Google Client performs some verification to ensure credentials match the cloud provider.
stanhu
added a commit
to fog/fog-google
that referenced
this pull request
Jan 29, 2026
This replaces the parameter introduced in #650. universe_domain was introduced in googleapis/google-api-ruby-client#17131 and googleapis/google-auth-library-ruby#460. This is preferable because the Google Client performs some verification to ensure credentials match the cloud provider.
stanhu
added a commit
to fog/fog-google
that referenced
this pull request
Jan 29, 2026
This replaces the parameter introduced in #650. universe_domain was introduced in googleapis/google-api-ruby-client#17131 and googleapis/google-auth-library-ruby#460. This is preferable because the Google Client performs some verification to ensure credentials match the cloud provider.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates to the client base class to support universe domain.
This is the bulk of the change necessary to support universe_domain in these clients. After this is released, the generated code can be updated to pass a template in as the endpoint.
Specifically:
$UNIVERSE_DOMAIN$is passed inThis preserves existing behavior for older clients that set static endpoints (which are now simply treated as endpoint overrides) while implementing full universe_domain support for newer clients that set endpoints with the substitution string.