Skip to content

Conversation

@bjwatson
Copy link

@bjwatson bjwatson commented Nov 1, 2016

@nathanielmanistaatgoogle @jonparrott Most of this change is regenerating the docs using the docs/build script. The rest is just adding to the CHANGELOG, and bumping the version in __init__.py.

I just did this as a point release, but can make it a minor release if you think adding a keyword arg to media upload methods qualifies as "adding new functionality".

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 1, 2016
Copy link
Contributor

@nathanielmanistaatgoogle nathanielmanistaatgoogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve; leaving unmerged in case @jonparrott spots anything in his review.

@theacodes
Copy link
Contributor

@bjwatson can you rebase to pull in #303?

@bjwatson
Copy link
Author

bjwatson commented Nov 2, 2016

@jonparrott Done. PTAL

@theacodes
Copy link
Contributor

LGTM

On Tue, Nov 1, 2016, 5:04 PM Brian J. Watson notifications@github.com
wrote:

@jonparrott https://github.com/jonparrott Done. PTAL


You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
#304 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAPUcyfcBdeMXPsCl4fL4Wxh6kebQLybks5q59OEgaJpZM4Klrtn
.

@bjwatson bjwatson merged commit f19307d into googleapis:master Nov 2, 2016
@bjwatson bjwatson deleted the changelog-1.5.5 branch November 2, 2016 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants