Skip to content

Conversation

@graingert
Copy link

No description provided.

@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Oct 13, 2015
@graingert
Copy link
Author

I signed it!

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Oct 13, 2015
@nathanielmanistaatgoogle
Copy link
Contributor

This smells like a change that is at least as political as it is technical. What's the story? Why was uritemplate forked? When's it going to be unforked?

@pferate
Copy link
Contributor

pferate commented Oct 18, 2015

I agree @nathanielmanistaatgoogle. It doesn't look like it's a fork, just a separate implementation of the same RFC. On PyPI, they were both last updated 2 years ago, although they both have updated on GitHub since then. I would recommend staying with the code base maintained by the RFC authors, unless there is a compelling reason not to.

@graingert
Copy link
Author

@pferate it looks like they're both alive again let's stick with the current package

@graingert graingert closed this Oct 18, 2015
@graingert graingert deleted the patch-1 branch October 18, 2015 08:37
simon-weber added a commit to venmo/google-api-python-client that referenced this pull request Dec 3, 2015
simon-weber added a commit to venmo/google-api-python-client that referenced this pull request Dec 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants