More efficient file upload from URL#548
Merged
ianbarber merged 1 commit intogoogleapis:masterfrom May 17, 2015
woofyman99:master
Merged
More efficient file upload from URL#548ianbarber merged 1 commit intogoogleapis:masterfrom woofyman99:master
ianbarber merged 1 commit intogoogleapis:masterfrom
woofyman99:master
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
googlebot
added
the
cla: no
Contributor
|
Any chance you could sign in the CLA - link in the bot comment? Understand if not, but we need it for any changes. |
Contributor
Author
|
No problem, done. |
|
CLAs look good, thanks! |
googlebot
added
cla: yes
Contributor
|
Thanks! |
ianbarber
added a commit
that referenced
this pull request
May 17, 2015
More efficient file upload from URL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While the sample code works file from a local file. If you're reading from a URL, it's very inefficient. The sample code here is reading from a URL and is very inefficient.
https://developers.google.com/youtube/v3/code_samples/php#resumable_uploads
It looks like it was pulled directly from the sample code in GitHub