Skip to content

chore: fix generator by pinning auth dep, updating samples TS version - #3941

Merged
pearigee merged 2 commits into
mainfrom
pearigee-fix-generator
Jul 24, 2026
Merged

chore: fix generator by pinning auth dep, updating samples TS version#3941
pearigee merged 2 commits into
mainfrom
pearigee-fix-generator

Conversation

@pearigee

@pearigee pearigee commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Issues addressed

Auth library conflict

npm install triggered npm run prepare (tsc), which failed with 9 TypeScript compilation errors due to duplicate module resolutions of google-auth-library. Top-level package.json resolved v10.9.1 while googleapis-common pinned v10.5.0, causing npm to create a nested copy and TypeScript to flag incompatible class type instances.

Pinning google-auth-library to 10.5.0 aligns root requirements with googleapis-common, allowing npm to deduplicate the package into top-level node_modules and resolving all build errors.

Samples type breakage due to outdated TS depedency

During tsc execution in samples/typescript:

  • samples/package.json had specified an outdated TypeScript version (^4.6.4).
  • tsc resolved @types/node from the root project's node_modules (version 22.15.3).
  • TypeScript 4.6 is incompatible with Node 22 type declarations in @types/node/web-globals/streams.d.ts, leading to compile error:
    error TS2502: 'CompressionStream' is referenced directly or indirectly in its own type annotation.

@pearigee
pearigee requested a review from a team as a code owner July 24, 2026 22:18
@product-auto-label product-auto-label Bot added the size: xs Pull request size is extra small. label Jul 24, 2026
@pearigee
pearigee enabled auto-merge (squash) July 24, 2026 22:21
@pearigee pearigee added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 24, 2026
During tsc execution in samples/typescript:

* samples/package.json had specified an outdated TypeScript version (^4.6.4).
* tsc resolved @types/node from the root project's node_modules (version 22.15.3).
* TypeScript 4.6 is incompatible with Node 22 type declarations in @types/node/web-globals/streams.d.ts, leading to compile error:
error TS2502: 'CompressionStream' is referenced directly or indirectly in its own type annotation.
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 24, 2026
@pearigee pearigee changed the title chore: fix generator by pinning auth dep chore: fix generator by pinning auth dep & updating sample's TS version Jul 24, 2026
@pearigee pearigee changed the title chore: fix generator by pinning auth dep & updating sample's TS version chore: fix generator by pinning auth dep, updating samples' TS version Jul 24, 2026
@pearigee pearigee changed the title chore: fix generator by pinning auth dep, updating samples' TS version chore: fix generator by pinning auth dep, updating samples TS version Jul 24, 2026
@pearigee
pearigee merged commit add3e9a into main Jul 24, 2026
23 checks passed
@pearigee
pearigee deleted the pearigee-fix-generator branch July 24, 2026 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants