Skip to content

ci: use maven wrapper with version 3.8.7 to fix google-play-services artifact install #2269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
emmileaf merged 8 commits into from
Feb 24, 2023
Merged

ci: use maven wrapper with version 3.8.7 to fix google-play-services artifact install #2269

emmileaf merged 8 commits into from
Feb 24, 2023

Conversation

@emmileaf
Copy link
Contributor

@emmileaf emmileaf commented Feb 22, 2023 •
edited
Loading

The ci / windows check has a call to mvn install:install-file that is erroring on NPE from a regression in Maven 3.9.0: https://issues.apache.org/jira/browse/MNG-7679. This PR adds a workaround to this workflow by setting up and calling maven wrapper with fixed version 3.8.7.

Note: this PR and the clirr fix in #2268 mutually unblock each other (and a number of other open PRs in this repo).

Error log on ci / windows check:

Downloaded from central: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-install-plugin/3.1.0/maven-install-plugin-3.1.0.jar (30 kB at 947 kB/s)
[INFO] 
[INFO] ------------------< org.apache.maven:standalone-pom >-------------------
[INFO] Building Maven Stub Project (No POM) 1
[INFO] --------------------------------[ pom ]---------------------------------
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  2.125 s
[INFO] Finished at: 2023-02-15T12:35:20Z
[INFO] ------------------------------------------------------------------------
Error:  NullPointerException
java.lang.NullPointerException
    at org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.getProjectAndSubModules (LifecycleDependencyResolver.java:102)
    at org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.getProjects (LifecycleDependencyResolver.java:93)
    at org.apache.maven.lifecycle.internal.MojoExecutor.ensureDependenciesAreResolved (MojoExecutor.java:395)

@emmileaf emmileaf requested a review from a team as a code owner February 22, 2023 20:58
@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Feb 22, 2023 •
edited
Loading

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Feb 22, 2023
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: xs Pull request size is extra small. labels Feb 22, 2023
@emmileaf emmileaf changed the title [do not merge] ci: troubleshooting google-play-services artifact install for Windows ci: add maven wrapper with version 3.6.7 to fix google-play-services artifact install for Windows Feb 22, 2023
@emmileaf emmileaf changed the title ci: add maven wrapper with version 3.6.7 to fix google-play-services artifact install for Windows ci: add maven wrapper with version 3.8.7 to fix google-play-services artifact install Feb 22, 2023
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. and removed size: l Pull request size is large. labels Feb 22, 2023
@emmileaf emmileaf mentioned this pull request Feb 22, 2023
Merged
@emmileaf emmileaf changed the title ci: add maven wrapper with version 3.8.7 to fix google-play-services artifact install ci: use maven wrapper with version 3.8.7 to fix google-play-services artifact install Feb 22, 2023
@emmileaf emmileaf mentioned this pull request Feb 24, 2023
Closed
@emmileaf emmileaf merged commit 8f1b4c9 into main Feb 24, 2023
@emmileaf emmileaf deleted the ci-windows-test branch February 24, 2023 21:52
emmileaf added a commit that referenced this pull request Jul 6, 2023
@emmileaf
Revert "ci: use maven wrapper with version 3.8.7 to fix google-play-s…
02332d6 
…ervices artifact install (#2269)"

This reverts commit 8f1b4c9.
@emmileaf emmileaf mentioned this pull request Jul 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blakeli0 blakeli0 blakeli0 approved these changes

@meltsufin meltsufin Awaiting requested review from meltsufin

Assignees

No one assigned

Labels

size: xs Pull request size is extra small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@emmileaf @blakeli0