Skip to content

Conversation

@andrey-qlogic
Copy link
Contributor

@andrey-qlogic andrey-qlogic commented Nov 28, 2018

and AbstractGoogleClientRequest.

Fixes googleapis/google-cloud-java#3822 (it's a good idea to open an issue first for discussion)

  • Tests pass
  • Appropriate docs were updated (if necessary)

@andrey-qlogic andrey-qlogic requested a review from a team as a code owner November 28, 2018 11:49
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Nov 28, 2018
@sduskis
Copy link

sduskis commented Nov 28, 2018

@andrey-qlogic, can you please sign the CLA?

@sduskis sduskis added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Nov 28, 2018
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@sduskis
Copy link

sduskis commented Nov 28, 2018

@andrey-qlogic signed the CLA, but didn't comment with "I signed it!"

@andrey-qlogic
Copy link
Contributor Author

I signed it!

@sduskis sduskis changed the title 3822: Added contentOffset to MediaHttpUploader and AbstractGoogleClie… 3822: Added contentOffset to MediaHttpUploader Dec 3, 2018
@sduskis
Copy link

sduskis commented Dec 3, 2018

@andrey-qlogic, does this fix an issue? If so can, you please add the issue # in the description?

@andrey-qlogic andrey-qlogic changed the title 3822: Added contentOffset to MediaHttpUploader #3822: Added contentOffset to MediaHttpUploader Dec 3, 2018
@googlebot
Copy link

CLAs look good, thanks!

@andrey-qlogic
Copy link
Contributor Author

@chingor13 thanks for review, the good point about -1 value.

@andrey-qlogic
Copy link
Contributor Author

@chingor13 The comment fixed: Don't add contentOffset when it -1

@andrey-qlogic
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants