Raw page #238
Merged
Raw page #238
+83
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
software-dov
requested review from
busunkim96,
crwilcox,
lukesneeringer and
nnegrey
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #238 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 25 25
Lines 1285 1285
Branches 276 276
=====================================
Hits 1285 1285Continue to review full report at Codecov.
|
busunkim96
approved these changes
Nov 7, 2019
Contributor
busunkim96
left a comment
busunkim96
left a comment
There was a problem hiding this comment.
LGTM, although someone else familiar with the generator should also take a look.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation for #237 , corresponds to googleapis/google-cloud-python#9486