Skip to content

fix: implement Async Client to use Async Retry to work as expected #1823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ohmayr merged 3 commits into from
Nov 3, 2023
Merged

fix: implement Async Client to use Async Retry to work as expected #1823

ohmayr merged 3 commits into from
Nov 3, 2023

Conversation

@ohmayr
Copy link
Contributor

@ohmayr ohmayr commented Oct 24, 2023 •
edited
Loading

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Oct 24, 2023
@ohmayr ohmayr force-pushed the fix-retry-in-async-client branch from f48909d to b320125 Compare October 25, 2023 17:37
@ohmayr ohmayr marked this pull request as ready for review October 25, 2023 17:54
@ohmayr ohmayr requested a review from a team as a code owner October 25, 2023 17:54
@ohmayr
fix: retry for async clients
478b055 
- update Async Clients to use google.api_core.retry_async.AsyncRetry
- add a unit test for testing Async Retry
@ohmayr ohmayr force-pushed the fix-retry-in-async-client branch from b320125 to 449b185 Compare October 25, 2023 22:58
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Oct 25, 2023
@ohmayr ohmayr force-pushed the fix-retry-in-async-client branch 2 times, most recently from 0ff0980 to 478b055 Compare October 30, 2023 15:49
@ohmayr ohmayr changed the title Implement Async Client to use Async Retry to work as expected Fix: Implement Async Client to use Async Retry to work as expected Oct 30, 2023
vchudnov-g
vchudnov-g approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@vchudnov-g vchudnov-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! Were you able to verify that the modified generated code exhibits the right async behavior now?

@ohmayr
Copy link
Contributor Author

ohmayr commented Nov 3, 2023

Thanks for doing this! Were you able to verify that the modified generated code exhibits the right async behavior now?

I've added a test case with this PR to verify the behaviour of AsyncClient i.e. I've verified that the test fails without the changes and works as expected after updating asyncClient to use asyncRetry.

@ohmayr ohmayr merged commit 8ede788 into main Nov 3, 2023
@ohmayr ohmayr deleted the fix-retry-in-async-client branch November 3, 2023 16:57
@release-please release-please bot mentioned this pull request Nov 3, 2023
Merged
@vchudnov-g vchudnov-g changed the title Fix: Implement Async Client to use Async Retry to work as expected fix: implement Async Client to use Async Retry to work as expected Nov 6, 2023
@daniel-sanche daniel-sanche mentioned this pull request Nov 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vchudnov-g vchudnov-g vchudnov-g approved these changes

Assignees

No one assigned

Labels

size: l Pull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Async clients do not document and implement retries correctly (and hence retries don't work)

2 participants

@ohmayr @vchudnov-g