This repository was archived by the owner on Apr 3, 2024. It is now read-only.
switch to using @google-cloud/common#190
Merged
ofrobots merged 1 commit intogoogleapis:masterfrom Dec 15, 2016
Merged
Conversation
googlebot
added
the
cla: yes
Contributor
Author
|
Travis fix: #191 |
matthewloring
approved these changes
Dec 14, 2016
Contributor
matthewloring
left a comment
matthewloring
left a comment
There was a problem hiding this comment.
We will still need to switch the logger before dropping the dependency on diagnostics-common. googleapis/google-cloud-node#1876 has landed and should release soon.
Contributor
Author
|
We also need googleapis/google-cloud-node#1879 to be able to drop the dependency on diagnostics-common. |
Contributor
Author
|
Further, even though this isn't a blocker for development, before we release we would want a resolution on googleapis/google-cloud-node#1822. |
ofrobots
added a commit
that referenced
this pull request
Dec 15, 2016
grpc is not supported with Node 7 on Windows at the moment. Stop building in that config for now. See #190 for more context.
This PR starts using the authorized / retry request flow from the @google-cloud/common library. From an operational perspective This shouldn't change behaviour significantly – although there are small differences in how the new library does retries or how it prioritizes different sources of the projectId & credentials (environment vs. metadata vs. config).
ofrobots
force-pushed
the
gcloud-common-2
branch
from
2d15078 to
ba52554
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR starts using the authorized / retry request flow from the
@google-cloud/common library. From an operational perspective This
shouldn't change behaviour significantly – although there are small
differences in how the new library does retries or how it prioritizes
different sources of the projectId & credentials (environment vs.
metadata vs. config).