Skip to content
This repository was archived by the owner on Apr 3, 2024. It is now read-only.

chore: pin @fastify/busboy to a version that supports node 12#1130

Merged
gcf-merge-on-green[bot] merged 3 commits intogoogleapis:mainfrom
mctavish:pin-busboy
Jan 13, 2023
Merged

chore: pin @fastify/busboy to a version that supports node 12#1130
gcf-merge-on-green[bot] merged 3 commits intogoogleapis:mainfrom
mctavish:pin-busboy

Conversation

@mctavish
Copy link
Contributor

@mctavish mctavish commented Jan 13, 2023

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1129 🦕

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: clouddebugger Issues related to the googleapis/cloud-debug-nodejs API. labels Jan 13, 2023
@codecov
Copy link

codecov bot commented Jan 13, 2023

Codecov Report

Base: 65.88% // Head: 65.88% // No change to project coverage 👍

Coverage data is based on head (ae85b74) compared to base (443e902).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1130   +/-   ##
=======================================
  Coverage   65.88%   65.88%           
=======================================
  Files          21       21           
  Lines        1791     1791           
  Branches      355      355           
=======================================
  Hits         1180     1180           
  Misses        524      524           
  Partials       87       87           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mctavish mctavish added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 13, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 13, 2023
@mctavish mctavish marked this pull request as ready for review January 13, 2023 20:12
@mctavish mctavish requested a review from a team as a code owner January 13, 2023 20:12
@mctavish mctavish requested review from a team and jasonborg January 13, 2023 20:12
@mctavish mctavish added the automerge Merge the pull request once unit tests and other checks pass. label Jan 13, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit 5b8d3b1 into googleapis:main Jan 13, 2023
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jan 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: clouddebugger Issues related to the googleapis/cloud-debug-nodejs API. size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to install on Node 12

2 participants