Update retrieval of customer ID - #262
Merged
Merged
Conversation
wihl
reviewed
Apr 13, 2020
wihl
approved these changes
Apr 13, 2020
AnashOommen
reviewed
Apr 16, 2020
BenRKarl
force-pushed
the
customer_id_resource_name
branch
from
April 16, 2020 20:25
13623c4 to
25d023d
Compare
wihl
reviewed
Apr 17, 2020
AnashOommen
approved these changes
Apr 17, 2020
AnashOommen
left a comment
AnashOommen
left a comment
Member
There was a problem hiding this comment.
Reviewed the implementation with Ben offline. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
GetCustomerRequestobject sends a resource name instead of a customer ID so this updates the logging interceptor slightly to parse the customer ID from it.Mirroring change made in Ruby here: https://github.com/googleads/google-ads-ruby/pull/29/files