Update the gemini review toml to send correct response with no tags#405
Closed
megha1188 wants to merge 0 commit intogoogle-github-actions:mainfrom
Closed
Update the gemini review toml to send correct response with no tags#405megha1188 wants to merge 0 commit intogoogle-github-actions:mainfrom
megha1188 wants to merge 0 commit intogoogle-github-actions:mainfrom
Conversation
megha1188
requested review from
HassanJasim,
R2wenD2,
haroonc and
kklashtorny1
Contributor
Author
|
@gemini-cli /review |
1 similar comment
Collaborator
|
@gemini-cli /review |
Contributor
|
🤖 Hi @MJjainam, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
![gemini-cli[bot]](https://avatars.githubusercontent.com/in/1473539?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
This pull request proposes a targeted and effective improvement to the prompt templates used in the gemini-review.toml files. By removing the <COMMENT> and <SUMMARY> tags, the change simplifies the prompt and reduces the likelihood of the model generating improperly formatted responses.
🔍 General Feedback
- The change is well-reasoned and directly addresses a potential source of output variability.
- Applying the update to both the base command and the example workflow ensures consistency.
- This is a good example of a small but impactful change to improve prompt reliability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the gemini-review.toml prompt template to remove several extra newline characters.
These newlines were causing the model to sometimes generate responses with incorrect formatting or unwanted tags. Removing them cleans up the prompt and ensures the model's output more reliably adheres to the desired structure.
The change is applied to both the default command prompt and the example workflow prompt.