node: add knex example to sample#27
Merged
balachandr merged 3 commits intogoogle:masterfrom Jan 12, 2021
Merged
Conversation
aabmass
force-pushed
the
sample-knex-express
branch
from
62a8493 to
15b8a07
Compare
aabmass
changed the title
aabmass
force-pushed
the
sample-knex-express
branch
from
15b8a07 to
335b29a
Compare
aabmass
commented
Nov 11, 2020
Member
Author
aabmass
left a comment
aabmass
left a comment
There was a problem hiding this comment.
I need to update the README still
aabmass
force-pushed
the
sample-knex-express
branch
from
335b29a to
b96421e
Compare
Member
Author
|
Ready for review :) |
aabmass
force-pushed
the
sample-knex-express
branch
from
b96421e to
8bbe52d
Compare
odeke-em
suggested changes
Nov 11, 2020
Comment on lines
7
to
9
| client_timezone: true, | ||
| db_driver: true, | ||
| route: true, |
Contributor
There was a problem hiding this comment.
This are supposed to be optional, let's add a disclaimer here that adding these fields isn't mandatory and will cause a high cardinality burst. Actually I'd start with firstly putting the most important fields traceparent and tracestate then these 3 below them after a newline, and with the comment.
Member
Author
There was a problem hiding this comment.
Ok will do. The actual code defaults should probably be updated, too:
Member
Author
There was a problem hiding this comment.
let me know how it looks now
Member
Author
|
I have orijtech/sqlcommenter-website#72 open, which updates the documentation to link to these examples |
balachandr
approved these changes
Dec 1, 2020
Member
Author
|
@balachandr fixed the conflicts |
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #26.
This adds a server using knex that does the same thing as the sequelize one. Because of #25, this won't work with node versions older than 14.5.0.
Also, updated
package.jsonto install dependencies from tarball, which is works like installing from npm registry directly.